Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't crash in Query.count() when table is not defined #6453

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Don't crash in Query.count() when table is not defined #6453

merged 1 commit into from
Mar 31, 2023

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Mar 30, 2023

What, How & Why?

Fixes #6443

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed.

finnschiermer
finnschiermer approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@finnschiermer finnschiermer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EPIC!

@jedelbo jedelbo merged commit a12241b into master Mar 31, 2023
@jedelbo jedelbo deleted the je/query-count branch March 31, 2023 06:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@finnschiermer finnschiermer finnschiermer approved these changes

Assignees

@jedelbo jedelbo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when invoking .count() on an empty results
2 participants
@jedelbo @finnschiermer