Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bindgen] follow up to #7300 #7623

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Conversation

kneth
Copy link
Contributor

@kneth kneth commented Apr 25, 2024

What, How & Why?

#7300 comes with a number of breaking changes and new APIs. This PR follows up on #7300 to work around some limitations in the Binding Generator. Moreover, the PR fixes a couple of typos.

☑️ ToDos

  • [ ] 📝 Changelog update
  • [ ] 🚦 Tests (or not relevant)
  • [ ] C-API, if public C++ API changed
  • [ ] bindgen/spec.yml, if public C++ API changed

@kneth kneth requested a review from tgoyne April 25, 2024 10:55
@cla-bot cla-bot bot added the cla: yes label Apr 25, 2024
@kneth kneth requested review from jedelbo and jsflax April 25, 2024 10:56
@kneth kneth added no-changelog no-jira-ticket Skip checking the PR title for Jira reference labels Apr 25, 2024
Copy link

coveralls-official bot commented Apr 25, 2024

Pull Request Test Coverage Report for Build kenneth.geisshirt_12

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 83 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.736%

Files with Coverage Reduction New Missed Lines %
src/realm/sync/noinst/server/server_history.cpp 1 63.76%
src/realm/cluster.cpp 2 75.87%
src/realm/sync/network/http.hpp 2 82.27%
src/realm/unicode.cpp 3 83.83%
test/test_thread.cpp 3 64.69%
src/realm/sync/noinst/client_reset.cpp 4 91.93%
src/realm/sync/noinst/client_reset_operation.cpp 5 86.79%
src/realm/index_string.cpp 6 84.83%
src/realm/sync/noinst/protocol_codec.hpp 6 73.5%
src/realm/sync/noinst/client_impl_base.cpp 9 82.38%
Totals Coverage Status
Change from base Build 2257: -0.02%
Covered Lines: 211928
Relevant Lines: 233566

💛 - Coveralls

bindgen/spec.yml Outdated Show resolved Hide resolved
@kneth kneth marked this pull request as draft April 25, 2024 14:28
@kneth kneth removed request for tgoyne and jsflax April 25, 2024 14:28
@kneth kneth marked this pull request as ready for review April 25, 2024 16:40
@jedelbo jedelbo merged commit bec09f8 into master Apr 26, 2024
39 of 41 checks passed
@jedelbo jedelbo deleted the kneth/bindgen/workaround-limitations branch April 26, 2024 08:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-changelog no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants