-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
realm compact #1005
realm compact #1005
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think it is prudent not to spawn an isolate - users can do that themselves. Would be nice if realm-core exposed an async interface for this though.
Pull Request Test Coverage Report for Build 3387542209
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3394922515
💛 - Coveralls |
@nielsenko added a test for a worker isolate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to test if:
- a compacted realm could be opened
- a synced realm populated with data could be compacted and the opened with the same number of rows.
- the size of compacted realm file is less than the size of a synced populated ream that had been frozen before the compaction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API should be sync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly there - the main remaining thing is to make sure we're not polluting tests by subscribing to all objects from a collection.
add a test
pass disconnectedsync config as is
Co-authored-by: Desislava Stefanova <95419820+desistefanova@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added some small suggestions about formatting and naming. It looks good.
Support realm compact.
fixes #803