Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write copy #1103

Merged
merged 25 commits into from
Jan 20, 2023
Merged

Write copy #1103

merged 25 commits into from
Jan 20, 2023

Conversation

desistefanova
Copy link
Contributor

@desistefanova desistefanova commented Jan 15, 2023

Implement writeCopy that copies realm file:
Local to Local
Local to Local read-only
Local in-memory to Local
Local to Sync - not supported
Sync to Sync
Sync to Local

Copy to file path is about to be deprecated.
Fixes #796

@coveralls
Copy link

coveralls commented Jan 15, 2023

Pull Request Test Coverage Report for Build 3968063959

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 88.74%

Totals Coverage Status
Change from base Build 3967893353: 0.05%
Covered Lines: 2987
Relevant Lines: 3366

💛 - Coveralls

@desistefanova desistefanova marked this pull request as ready for review January 16, 2023 07:23
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
test/realm_test.dart Outdated Show resolved Hide resolved
desistefanova and others added 2 commits January 17, 2023 16:00
Co-authored-by: Kasper Overgård Nielsen <kasper.nielsen@mongodb.com>
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should disallow calling copy from within write transactions and migrations.

lib/src/realm_class.dart Outdated Show resolved Hide resolved
lib/src/realm_class.dart Outdated Show resolved Hide resolved
lib/src/realm_class.dart Outdated Show resolved Hide resolved
lib/src/realm_class.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Show resolved Hide resolved
test/realm_test.dart Outdated Show resolved Hide resolved
test/realm_test.dart Outdated Show resolved Hide resolved
test/realm_test.dart Outdated Show resolved Hide resolved
test/realm_test.dart Outdated Show resolved Hide resolved
test/realm_test.dart Show resolved Hide resolved
desistefanova and others added 2 commits January 19, 2023 00:08
Co-authored-by: blagoev <lubo@blagoev.com>
@desistefanova desistefanova marked this pull request as draft January 19, 2023 12:49
@desistefanova desistefanova marked this pull request as ready for review January 19, 2023 14:29
lib/src/realm_class.dart Outdated Show resolved Hide resolved
test/realm_test.dart Outdated Show resolved Hide resolved
test/realm_test.dart Show resolved Hide resolved
@desistefanova desistefanova merged commit a7f13b7 into main Jan 20, 2023
@desistefanova desistefanova deleted the ds/write_copy branch January 20, 2023 13:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

realm.WriteCopyLocalToSync and SyncToLocal, LocalToLocal, SyncToSync
4 participants