-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common sync schema collection for all tests #1399
Merged
desistefanova
merged 5 commits into
ds/core13.19_sync_errors_changes
from
ds/common_test_schemas_new__baas
Sep 15, 2023
Merged
Common sync schema collection for all tests #1399
desistefanova
merged 5 commits into
ds/core13.19_sync_errors_changes
from
ds/common_test_schemas_new__baas
Sep 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desistefanova
changed the base branch from
main
to
ds/core13.19_sync_errors_changes
September 14, 2023 14:54
desistefanova
changed the title
Experimental: Common test schema collection for all tests
Experimental: Common sync schema collection for all tests
Sep 14, 2023
nielsenko
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.. once all the test pass 😅 |
nielsenko
approved these changes
Sep 15, 2023
desistefanova
changed the title
Experimental: Common sync schema collection for all tests
Common sync schema collection for all tests
Sep 15, 2023
blagoev
reviewed
Sep 15, 2023
blagoev
approved these changes
Sep 15, 2023
desistefanova
merged commit Sep 15, 2023
e92848c
into
ds/core13.19_sync_errors_changes
17 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created to avoid removing schemas when breaking changes are allowed in dev mode in the new baas version.