RDART-973: Add support for the new progress notifications #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: (28 commits) Wrong test for local development (#1591) Add vNext Changelog header (#1589) [Release 2.0.0-beta.2] (#1588) Update melos to 5.2.0 (#1587) RDART-977: Hierarchical logger (#1574) Fix release workflow (#1582) RDART-978: Add support RealmValue.fromJson (#1581) Fix oversight in install command Add vNext Changelog header (#1579) [Release 2.0.0-beta.1] (#1577) RDART-976: Fix install command (#1576) Update build instructions and switching Flutter/Dart versions (#1571) gitignore release folder Remove incorrectly committed files Cleanup changelog, bring back melos publishing (#1573) Add vNext Changelog header (#1572) [Release 2.0.0-alpha.5] (#1570) Revert "Copy symlinks for realm_dart" Copy symlinks for realm_dart Fix changelog ... # Conflicts: # packages/realm_dart/lib/src/session.dart # packages/realm_dart/src/realm-core # packages/realm_dart/test/realm_test.dart # packages/realm_dart/test/session_test.dart # packages/realm_dart/test/test.dart
nirinchev
changed the title
nielsenko
approved these changes
Apr 11, 2024
Comment on lines
+217
to
+230
| // We should not see more updates in either direction | ||
| final uploadCallbacks = uploadData.callbacksInvoked; | ||
| final downloadCallbacks = downloadData.callbacksInvoked; | ||
|
|
||
| uploadRealm.write(() { | ||
| uploadRealm.add(NullableTypes(ObjectId(), differentiator, stringProp: generateRandomString(50))); | ||
| }); | ||
|
|
||
| await uploadRealm.syncSession.waitForUpload(); | ||
| await downloadRealm.syncSession.waitForDownload(); | ||
|
|
||
| expect(uploadRealm.all<NullableTypes>().length, downloadRealm.all<NullableTypes>().length); | ||
| expect(uploadData.callbacksInvoked, uploadCallbacks); | ||
| expect(downloadData.callbacksInvoked, downloadCallbacks); |
There was a problem hiding this comment.
Could you elaborate the explanation of this part a bit? Why will we not see more upload callbacks here, when we add and wait for upload?
There was a problem hiding this comment.
Because the subscription we setup is for ProgressMode.forCurrentlyOutstandingWork, which ends when you've reached 100% and no further callbacks will be invoked as more data comes in/goes out.
packages/realm_dart/test/test.dart
Outdated
| @@ -418,7 +418,7 @@ void setupTests() { | |||
|
|
|||
| Realm.logger.setLogLevel(LogLevel.detail); | |||
| Realm.logger.onRecord.listen((record) { | |||
| testing.printOnFailure('${record.category} ${record.level.name}: ${record.message}'); | |||
| testing.printOnFailure('${DateTime.now().toUtc()} ${record.category} ${record.level.name}: ${record.message}'); | |||
|
Some test failures needs to be resolved |
* main: (37 commits) RDART-930: Refactor handles (#1550) Forgot to show GeoPolygon Add vNext Changelog header (#1687) [Release 2.3.0] (#1686) RDART-1028: Use Zone.current.bindUnaryCallbackGuarded for RawReceivePort.handler (#1683) RDART-1021: Wire up some basic dynamic setting and change notifications (#1669) RDART-1022: Drop x86 as target (#1682) RDART-1034: Update realm-core to v14.7.0 (#1681) Skip select test RDART-1018: Fix badly generated _fromJson (#1664) Add vNext Changelog header (#1660) [Release 2.2.1] (#1659) Update CHANGELOG.md RDART-1016: Cleanup iOS podspec (#1658) Add vNext Changelog header (#1655) [Release 2.2.0] (#1654) RDART-1015: Update core to v14.6.2 (#1651) RDART-950: Update nullability annotations for base url API (#1652) RDART-964: Add PrivacyInfo.xcprivacy for iOS and macOS (#1646) RDART-1014: Bump required sdk version to ^3.3.0 (#1648) ... # Conflicts: # CHANGELOG.md # packages/realm_dart/lib/src/native/realm_core.dart # packages/realm_dart/src/realm-core # packages/realm_dart/test/realm_test.dart # packages/realm_dart/test/session_test.dart # packages/realm_dart/test/test.dart
* main: RDART-1031: Disable codesign for apple binaries (#1694) RDART-1038: Drop keep alive hack (#1691)
Pull Request Test Coverage Report for Build 9649570041Details
💛 - Coveralls |
* main: Add vNext Changelog header (#1717) [Release 3.0.0] (#1716) libraryVersion moved to realm_libary.dart (take 2) libraryVersion moved to realm_libary.dart Update CHANGELOG (#1715) Github composite action for setting up flutter on runner (#1710) RDART-866: kn/decimal128 web support (#1713) Reduce expected gain of memEquals for test stability Refresh after awaiting download to stabilize tests RDART-866: Minimal web support (#1699) RDART-1052: Update realm-core to v14.9.0 (#1704) RDART-1020: Fix writeAsync behaviour (#1666) RDART-999: Fix flutter test dlopen (#1623) RDART-1045: Expose setrlimit ios (#1700) RDART-962: Use xcode 15.4 (#1548) RDART-1039: Drop catalyst support. Flutter doesn't support it (#1696) # Conflicts: # packages/realm_dart/src/realm-core
* main: Compensate for breaking change in sane_uuid (#1730)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1564
TODO: