RDART-962: Use xcode 15.4 #1548

nielsenko · 2024-03-08T14:46:13Z

Use macos-14 runner for arm64 and macos-13 runner for x86_64 (see https://github.com/actions/runner-images?tab=readme-ov-file)
Use xcode 15.4 which changes a bit how to build universal binaries.

coveralls-official · 2024-03-08T14:58:17Z

Pull Request Test Coverage Report for Build 9285323168

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.208%

Totals
Change from base Build 9267728256:	0.0%
Covered Lines:	5890
Relevant Lines:	6754

💛 - Coveralls

nirinchev · 2024-04-08T18:49:49Z

.github/workflows/dart-desktop-tests.yml

@@ -3,18 +3,10 @@ name: Dart desktop tests
 on:
  workflow_call:
    inputs:
-      os:


I'm not sure I'm a huge fan of the changes in this file. I understand that it removes some redundant pieces of information, but it complicates the setup somewhat and forces readers to familiarize themselves with the architectures of the various github-hosted runners.

The previous code had assumptions about the architecture, that didn't actually match the runners, implicitly assuming arch was x86_64 unless architecture was set to arm. That is not correct for macos-14, which is being rolled out as macos-latest as of yesterday (github/roadmap#926).

One thing I regret is that I cannot show the arch in the job title, as we don't know what runner is being used yet, so it is only shown in the steps. And obviously I would have preferred for github action expressions to be expressive enough to lowercase a simple string 🙄

What if I reintroduce the architecture argument, and make a step that explicitly test that it actually match runner.arch?

Sure, I'd be fine with that.

nirinchev · 2024-04-08T18:56:47Z

.github/workflows/ci.yml

-          submodules: 'recursive'
+          submodules: "recursive"
+
+      - name: Select XCode for MacOS


We need to increase the ulimit here it seems.

CHANGELOG.md

nielsenko · 2024-04-09T07:38:42Z

packages/realm_dart/scripts/build-macos.sh

@@ -7,4 +7,4 @@ set -o pipefail
 cd "$(dirname "$0")/.."

 cmake --preset macos
-cmake --build --preset macos --config MinSizeRel -- -destination "generic/platform=macOS"
+cmake --build --preset macos --config Release -- -destination "generic/platform=macOS"


MinSizeRel becomes -Os which apparently clang++ (from XCode 15.x) don't like, hence this change.

nielsenko · 2024-04-09T07:43:02Z

packages/realm_dart/CMakePresets.json

@@ -168,7 +168,7 @@
      "configurePreset": "macos",
      "nativeToolOptions": [
        "-destination",
-        "platform=macOS"
+        "generic/platform=macOS"


As of XCode 15.3 it is apparently important to use generic/platform=macOS during preset, to actually end up with a universal binary (ie. supporting both arm64 and x86_64).

The downside of this change is that we also build for x86_64 on our dev machines, but given that we use ccache it is perhaps a non-issue in practice.

Update CHANGELOG Use Release instead of MinSIzeRel

.github/workflows/build-native.yml

nirinchev · 2024-05-29T10:49:36Z

.github/workflows/build-native.yml

+      - name: Select XCode for MacOS
+        if: startsWith(inputs.runner, 'macos')
+        run: |
+          xcodes installed


Why do we need this?

We don't, but I find it useful to see what versions are available when looking at the output of the step

nirinchev · 2024-05-29T10:52:08Z

.github/workflows/dart-desktop-tests.yml

-        run: ulimit -n 10240
-        if: ${{ contains(inputs.os, 'macos') }}
+        run: |
+          ulimit -n


Why do we do this?

To see the current limit in the output of the step before setting it.

.github/workflows/flutter-desktop-tests.yml

Co-authored-by: Nikola Irinchev <irinchev@me.com>

* main: RDART-1020: Fix writeAsync behaviour (#1666) RDART-999: Fix flutter test dlopen (#1623) RDART-1045: Expose setrlimit ios (#1700) RDART-962: Use xcode 15.4 (#1548) # Conflicts: # packages/realm_dart/lib/src/cli/install/install_command.dart

* main: Add vNext Changelog header (#1717) [Release 3.0.0] (#1716) libraryVersion moved to realm_libary.dart (take 2) libraryVersion moved to realm_libary.dart Update CHANGELOG (#1715) Github composite action for setting up flutter on runner (#1710) RDART-866: kn/decimal128 web support (#1713) Reduce expected gain of memEquals for test stability Refresh after awaiting download to stabilize tests RDART-866: Minimal web support (#1699) RDART-1052: Update realm-core to v14.9.0 (#1704) RDART-1020: Fix writeAsync behaviour (#1666) RDART-999: Fix flutter test dlopen (#1623) RDART-1045: Expose setrlimit ios (#1700) RDART-962: Use xcode 15.4 (#1548) RDART-1039: Drop catalyst support. Flutter doesn't support it (#1696) # Conflicts: # packages/realm_dart/src/realm-core

cla-bot bot added the cla: yes label Mar 8, 2024

github-actions bot assigned nielsenko Mar 8, 2024

nielsenko force-pushed the kn/xcode-15 branch from cd7fe5b to c85a646 Compare March 8, 2024 14:48

nielsenko force-pushed the kn/xcode-15 branch 3 times, most recently from 19be2b2 to 17827e8 Compare March 8, 2024 17:58

nielsenko force-pushed the kn/xcode-15 branch from 17827e8 to 2dc939f Compare April 8, 2024 10:07

nielsenko changed the title ~~RDART-962: Use xcode 15.2~~ RDART-962: Use xcode 15.3 Apr 8, 2024

nielsenko force-pushed the kn/xcode-15 branch 5 times, most recently from 0fe31e9 to 3d02b62 Compare April 8, 2024 17:11

nielsenko marked this pull request as ready for review April 8, 2024 17:16

nielsenko requested review from nirinchev and fealebenpae April 8, 2024 17:17

nirinchev reviewed Apr 8, 2024

View reviewed changes

nielsenko commented Apr 9, 2024

View reviewed changes

nielsenko force-pushed the kn/xcode-15 branch 8 times, most recently from 1da63ba to f69615f Compare April 12, 2024 08:27

nielsenko force-pushed the kn/xcode-15 branch 2 times, most recently from 375ceae to ab64653 Compare April 24, 2024 14:54

nielsenko force-pushed the kn/xcode-15 branch from ab64653 to 2a66f66 Compare April 29, 2024 15:28

nielsenko force-pushed the kn/xcode-15 branch 3 times, most recently from 6fb86bd to 0247de5 Compare May 27, 2024 14:36

nielsenko requested a review from nirinchev May 28, 2024 08:26

nielsenko force-pushed the kn/xcode-15 branch 2 times, most recently from 3c999f4 to 49aa8af Compare May 28, 2024 08:32

nielsenko changed the title ~~RDART-962: Use xcode 15.3~~ RDART-962: Use xcode 15.4 May 28, 2024

nielsenko force-pushed the kn/xcode-15 branch from 49aa8af to 3ae2871 Compare May 28, 2024 08:39

nielsenko added 5 commits May 28, 2024 12:29

Use xcode 15.4

6495dc1

Update CHANGELOG Use Release instead of MinSIzeRel

bump ulimit on ios test

4c6550b

Check arch instead of inferring implicitly

5f6ecba

Update flutter-desktop-tests.yml to match dart-desktop-tests.yml

5c71762

Don't force XCode version on iOS tests (only on builds)

aae9729

nielsenko force-pushed the kn/xcode-15 branch from 69dd7b3 to 25c7967 Compare May 28, 2024 10:29

Run iOS test on macos-12

1e6a379

nielsenko force-pushed the kn/xcode-15 branch from 25c7967 to 1e6a379 Compare May 29, 2024 10:15

Update CHANGELOG

4ae3b8c

nirinchev approved these changes May 29, 2024

View reviewed changes

nielsenko and others added 2 commits May 29, 2024 13:01

PR feedback

010d57d

Co-authored-by: Nikola Irinchev <irinchev@me.com>

PR feedback 2

149fe39

nielsenko merged commit e2d9187 into main May 29, 2024
56 checks passed

nielsenko deleted the kn/xcode-15 branch May 29, 2024 13:56

github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RDART-962: Use xcode 15.4 #1548

RDART-962: Use xcode 15.4 #1548

nielsenko commented Mar 8, 2024 •

edited

Loading

coveralls-official bot commented Mar 8, 2024 •

edited

Loading

nirinchev Apr 8, 2024

nielsenko Apr 9, 2024

nirinchev Apr 9, 2024

nirinchev Apr 8, 2024

nielsenko Apr 9, 2024

nielsenko Apr 9, 2024

nirinchev May 29, 2024

nielsenko May 29, 2024

nirinchev May 29, 2024

nielsenko May 29, 2024 •

edited

Loading

RDART-962: Use xcode 15.4 #1548

RDART-962: Use xcode 15.4 #1548

Conversation

nielsenko commented Mar 8, 2024 • edited Loading

coveralls-official bot commented Mar 8, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9285323168

Details

💛 - Coveralls

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nielsenko May 29, 2024 • edited Loading

Choose a reason for hiding this comment

nielsenko commented Mar 8, 2024 •

edited

Loading

coveralls-official bot commented Mar 8, 2024 •

edited

Loading

nielsenko May 29, 2024 •

edited

Loading