Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDART-1082: Fix _openRealmLib #1766

Merged
merged 2 commits into from
Aug 1, 2024
Merged

RDART-1082: Fix _openRealmLib #1766

merged 2 commits into from
Aug 1, 2024

Conversation

nielsenko
Copy link
Contributor

Fixes: #1765

@cla-bot cla-bot bot added the cla: yes label Jul 31, 2024
@nielsenko nielsenko mentioned this pull request Jul 31, 2024
Closed
@nielsenko nielsenko requested a review from nirinchev July 31, 2024 12:50
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 10180363279

Details

  • 4 of 7 (57.14%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 86.85%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/realm_dart/lib/src/handles/native/init.dart 4 7 57.14%
Files with Coverage Reduction New Missed Lines %
packages/realm_dart/lib/src/handles/native/init.dart 6 48.65%
Totals Coverage Status
Change from base Build 10138989483: -0.06%
Covered Lines: 5977
Relevant Lines: 6882
💛 - Coveralls

@nielsenko nielsenko marked this pull request as ready for review August 1, 2024 09:12
@nielsenko nielsenko merged commit 25deb78 into main Aug 1, 2024
63 of 64 checks passed
@nielsenko nielsenko deleted the kn/fix_openRealmLib branch August 1, 2024 09:12
@nielsenko nielsenko changed the title Fix _openRealmLib RDART-1082: Fix _openRealmLib Aug 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nirinchev nirinchev nirinchev approved these changes

Assignees

@nielsenko nielsenko

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_openRealmLib fails for dart compile to exe
2 participants
@nielsenko @nirinchev