Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http transport #302

Merged
merged 10 commits into from
Apr 11, 2022
Merged

http transport #302

merged 10 commits into from
Apr 11, 2022

Conversation

nielsenko
Copy link
Contributor

@nielsenko nielsenko commented Mar 16, 2022 •
edited by desistefanova
Loading

Add support for http_transport. Fixes #300

@cla-bot cla-bot bot added the cla: yes label Mar 16, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1993436378

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.706%
Totals Coverage Status
Change from base Build 1961847570: 0.0%
Covered Lines: 402
Relevant Lines: 429
💛 - Coveralls

@nielsenko nielsenko force-pushed the http_transport branch 2 times, most recently from 9c197e6 to fb26972 Compare March 16, 2022 15:11
@nielsenko nielsenko changed the base branch from master to rollback-weak-handle-finalizer-hack March 16, 2022 15:11
@nielsenko nielsenko force-pushed the http_transport branch 2 times, most recently from f96586a to 21156f2 Compare March 17, 2022 08:03
@nielsenko nielsenko force-pushed the rollback-weak-handle-finalizer-hack branch from 4c66ff0 to b0b7a43 Compare March 17, 2022 14:27
@nielsenko nielsenko force-pushed the rollback-weak-handle-finalizer-hack branch from b0b7a43 to 717046e Compare March 18, 2022 13:23
@nielsenko nielsenko force-pushed the rollback-weak-handle-finalizer-hack branch from 717046e to 7c44f96 Compare March 22, 2022 15:43
@nielsenko nielsenko force-pushed the rollback-weak-handle-finalizer-hack branch from 7c44f96 to cf3de80 Compare March 23, 2022 14:27
@nielsenko nielsenko force-pushed the http_transport branch 2 times, most recently from 46bdc2b to 9ed782c Compare March 24, 2022 09:38
@nielsenko nielsenko force-pushed the rollback-weak-handle-finalizer-hack branch from cf3de80 to 8cd3bfc Compare March 24, 2022 15:15
@nielsenko nielsenko marked this pull request as ready for review March 25, 2022 12:52
@nielsenko
Copy link
Contributor Author

There are no tests yet, as there are too many dependencies not satisfied yet.

blagoev
blagoev suggested changes Mar 25, 2022
View reviewed changes
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
src/realm_dart_http_transport.cpp Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
@nielsenko nielsenko force-pushed the rollback-weak-handle-finalizer-hack branch from 8cd3bfc to 62459d7 Compare March 28, 2022 12:21
@nielsenko nielsenko force-pushed the rollback-weak-handle-finalizer-hack branch from 62459d7 to 8430d42 Compare March 29, 2022 07:50
@nielsenko nielsenko requested a review from blagoev March 29, 2022 09:40
blagoev
blagoev suggested changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
blagoev
blagoev suggested changes Mar 31, 2022
View reviewed changes
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
@nielsenko nielsenko force-pushed the rollback-weak-handle-finalizer-hack branch from 8430d42 to 51c683d Compare April 1, 2022 16:37
@nielsenko nielsenko force-pushed the gc-handles branch 2 times, most recently from 656b54d to 4630df3 Compare April 7, 2022 16:19
Base automatically changed from gc-handles to master April 11, 2022 16:57
@blagoev
Merge branch 'master' into http_transport
575af51 
# Conflicts:
#	lib/src/native/realm_bindings.dart
#	lib/src/native/realm_core.dart
#	src/realm_dart.cpp
#	src/realm_dart.h
@blagoev
fix bad merge
3e11322
@blagoev @desistefanova
Update lib/src/native/realm_core.dart
48dc4e6 
Co-authored-by: Desislava Stefanova <95419820+desistefanova@users.noreply.github.com>
@blagoev blagoev merged commit 1f6e88c into master Apr 11, 2022
@blagoev blagoev deleted the http_transport branch April 11, 2022 18:23
@SPSpisoft SPSpisoft mentioned this pull request Nov 5, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RedBeard0531 RedBeard0531 RedBeard0531 left review comments

@blagoev blagoev blagoev approved these changes

@desistefanova desistefanova desistefanova left review comments

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support http transport
5 participants
@nielsenko @coveralls @RedBeard0531 @blagoev @desistefanova