Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Realm compact on open #466

Merged
merged 26 commits into from
Apr 12, 2022
Merged

Realm compact on open #466

merged 26 commits into from
Apr 12, 2022

Conversation

desistefanova
Copy link
Contributor

Implement shouldCompactCallback function configuring a Realm to determine if it should be compacted before being returned. Fixes #299

@cla-bot cla-bot bot added the cla: yes label Apr 11, 2022
blagoev
blagoev suggested changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to fix up our api doc and remove the local variable if possible.

lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/configuration.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Apr 12, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2154767248

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.784%
Totals Coverage Status
Change from base Build 2154709129: 0.0%
Covered Lines: 391
Relevant Lines: 426
💛 - Coveralls

blagoev
blagoev suggested changes Apr 12, 2022
View reviewed changes
lib/src/configuration.dart Outdated Show resolved Hide resolved
lib/src/configuration.dart Outdated Show resolved Hide resolved
lib/src/configuration.dart Outdated Show resolved Hide resolved
lib/src/configuration.dart Outdated Show resolved Hide resolved
lib/src/configuration.dart Outdated Show resolved Hide resolved
desistefanova and others added 4 commits April 12, 2022 14:41
@desistefanova @blagoev
Update lib/src/configuration.dart
5196e0b 
Co-authored-by: blagoev <lubo@blagoev.com>
@desistefanova @blagoev
Update lib/src/configuration.dart
4e4897e 
Co-authored-by: blagoev <lubo@blagoev.com>
@desistefanova @blagoev
Update lib/src/configuration.dart
c727728 
Co-authored-by: blagoev <lubo@blagoev.com>
@desistefanova
Edit comment
abd87a4
@desistefanova desistefanova merged commit 911c2ea into master Apr 12, 2022
@desistefanova desistefanova deleted the realm_compact_on_open branch April 12, 2022 12:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blagoev blagoev blagoev approved these changes

@nielsenko nielsenko Awaiting requested review from nielsenko

@nirinchev nirinchev Awaiting requested review from nirinchev

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support realm compact on open
3 participants
@desistefanova @coveralls @blagoev