-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for API key provider #919
Conversation
Pull Request Test Coverage Report for Build 3161647487
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments.
Changelog is missing.
Co-authored-by: Desislava Stefanova <95419820+desistefanova@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some awaits were missing.
Co-authored-by: Desislava Stefanova <95419820+desistefanova@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find any test for serverApiKey. It would be nice to have. I am not sure if it is possible to generate any key. Maybe we can write a manual test, just to have it.
Co-authored-by: Desislava Stefanova <95419820+desistefanova@users.noreply.github.com>
# Conflicts: # src/realm_dart_sync.cpp
@desistefanova I've decided not to expose server API key since it's the same as user api key - see @ironage's comment here: realm/realm-core#5914 (comment). LMK if that makes sense to you. I can confirm that the server api key tests pass with the api key provider, so seems superficial indeed. @blagoev I merged this with master, so it's no longer touching the native implementation. |
@nirinchev But it is possible in the Atlas web UI to create API key that doesn't belong to any user. How the developers will be able to use this key? See the documentation |
They can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the expectLater
calls. Should we always await the action or that is not mandatory?
Adds support for API key provider and authentication.
User.apiKeys
. This is a client that exposes functionality for managing user API keys.Credentials.apiKey
andCredentials.serverApiKey
.User.accessToken
andUser.refreshToken
.I had to downgrade Core due to realm/realm-core#5890.
Fixes #393
Fixes #385
Fixes #386
Fixes #387
Fixes #388
Fixes #389
Fixes #390
Fixes #435
Fixes #433
Fixes #432
Fixes #394