Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change passing of tests on CI #3565

Closed
papafe opened this issue Apr 5, 2024 · 3 comments · Fixed by #3593
Closed

Change passing of tests on CI #3565

papafe opened this issue Apr 5, 2024 · 3 comments · Fixed by #3593
Assignees

Comments

@papafe
Copy link
Contributor

papafe commented Apr 5, 2024

As it is know, the steps of the workflow related to testing are failing only if there's an actual crash/error in the steps, but will succeed even if there are failing tests. The failing tests are then reported inside the checks that are created by the Code coverage workflow.
This causes some issues:

  • Due to an an issue with GitHub, the test results get attached to a random action, and it is cumbersome to find the original action responsible for it, especially for newcomers.
  • It is difficult to see the previous checks results.
  • In case of flaky test, it's not possible to just press "re-run failed jobs" to run only the failing test suites

For these reasons it would be probably beneficial to change how our CI works, so that the test steps are failing also due to failing tests. This would make our repo be aligned with the other SDKs

@papafe
Copy link
Contributor Author

papafe commented Apr 5, 2024

@rorbech Did I forget anything?

Copy link

sync-by-unito bot commented Apr 5, 2024

➤ PM Bot commented:

Jira ticket: RNET-1130

@rorbech
Copy link
Contributor

rorbech commented Apr 5, 2024

@rorbech Did I forget anything?

I think it catches the annoyances that I have stumbled upon 🎉

@papafe papafe self-assigned this May 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants