Adding RxJava example #1940
Merged
Adding RxJava example #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review: |
|
|
||
| # Things to keep in mind | ||
|
|
||
| - Observables might have a default `Scheduler` they operate on that is different than the one |
| } | ||
| } | ||
|
|
||
| productFlavors { |
There was a problem hiding this comment.
Can this be removed since it's an empty block?
There was a problem hiding this comment.
Yes, it should be removed.
|
This is good. I found it fairly comprehensive and covered some of the gotchas that I was wondering about. Other than the small things mentioned. |
| super.onCreate(savedInstanceState); | ||
| setContentView(R.layout.activity_main); | ||
| container = (ViewGroup) findViewById(R.id.list); | ||
| container.removeAllViews(); |
|
LGTM besides small comments 👍 |
|
Nice 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1710
This PR replaces #1870
It adds a new example project showing how Realm can interop with RxJava, especially it highlights some of our current caveats and show work-arounds.