mark constructor of RealmAsyncTask package protected #2676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
zaki50
force-pushed
the
my/api-review/RealmAsyncTask
branch
from
9fb8421
to
20c74b3
Compare
|
👍 Regarding the commit message. I would probably describe the reasoning the behind the change instead of the actual action if that makes sense, .e.g "Removed constructor from the public API as the method is not useful for public use and we want to keep the public API as clean as possible". That will provide better information for anyone in the future wondering. |
|
@cmelchior thanks. I've updated the message. |
zaki50
force-pushed
the
my/api-review/RealmAsyncTask
branch
from
20c74b3
to
0a95ac7
Compare
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1594. Merge all together in one release.
@realm/java
Final commit note:
Title: mark constructor of RealmAsyncTask package protected
Removed constructor from the public API as the method is not useful for public use and we want to keep the public API as clean as possible