@NotNull as alias for @Required #5161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhachicha
reviewed
Aug 25, 2017
| @@ -441,13 +459,13 @@ private boolean categorizeIndexField(Element element, VariableElement variableEl | |||
| private void categorizeRequiredField(Element element, VariableElement variableElement) { | |||
| if (Utils.isPrimitiveType(variableElement)) { | |||
| Utils.error(String.format(Locale.US, | |||
| "@Required annotation is unnecessary for primitive field \"%s\".", element)); | |||
| "@Required and @NotNull annotation is unnecessary for primitive field \"%s\".", element)); | |||
| // In order to fully support the Kotlin type system we interpret `@NotNull` as an alias | ||
| // for `@Required` | ||
| for (AnnotationMirror annotation : field.getAnnotationMirrors()) { | ||
| if (annotation.getAnnotationType().toString().equals("org.jetbrains.annotations.NotNull")) { |
There was a problem hiding this comment.
why not use field.getAnnotation(Required.class) ? you don't want to pull the dependency?
There was a problem hiding this comment.
You mean @NotNull, but yes.
| return; | ||
| } | ||
|
|
||
| if (Utils.isRealmList(variableElement) || Utils.isRealmModel(variableElement)) { | ||
| if (Utils.isRealmModel(variableElement)) { |
There was a problem hiding this comment.
why removing the isRealmList check?
There was a problem hiding this comment.
Because it conflicted with Kotlin mostly. RealmList is always non-null for managed object. I don't know why we didn't allow this to be set. At worst it would be redundant information.
nhachicha
approved these changes
Aug 25, 2017
GulajavaMinistudio
added a commit
to GulajavaMinistudio/realm-java
that referenced
this pull request
Aug 26, 2017
@NotNull as alias for @required (realm#5161)
zaki50
pushed a commit
that referenced
this pull request
Aug 29, 2017
This PR adds support for org.jetbrains.annotations.NotNull as an alias for @required. This means that Realm now understands the Kotlin type-system in the Realm schema. Previously we reported an error if you did @required RealmList<MyType> list = new RealmList<>();. It is a bit unclear why, since a RealmList is always non-null on managed objects. Since it made the interop with Kotlin kinda strange, I made a change so you can now do @required RealmList<MyType> list = new RealmLis<>() as well as val list : RealmList<MyType> = RealmList(); After this change it is no longer possible to do val person : Person either, you have to do val person : Person?. This reflects the constraints of Realm, but if people are able to maintain the variant themselves (hint: not possible when using sync), then they can use a custom non-null getter.
zaki50
added a commit
that referenced
this pull request
Sep 5, 2017
…sor) (#5168) * @NotNull as alias for @required (#5161) This PR adds support for org.jetbrains.annotations.NotNull as an alias for @required. This means that Realm now understands the Kotlin type-system in the Realm schema. Previously we reported an error if you did @required RealmList<MyType> list = new RealmList<>();. It is a bit unclear why, since a RealmList is always non-null on managed objects. Since it made the interop with Kotlin kinda strange, I made a change so you can now do @required RealmList<MyType> list = new RealmLis<>() as well as val list : RealmList<MyType> = RealmList(); After this change it is no longer possible to do val person : Person either, you have to do val person : Person?. This reflects the constraints of Realm, but if people are able to maintain the variant themselves (hint: not possible when using sync), then they can use a custom non-null getter. * implement elemenrt type check of RealmList * fix error message * remove extra line * fix typo * address review comments
zaki50
added a commit
that referenced
this pull request
Sep 5, 2017
* Add Primitive List fields to test classes * removed tests for Primitive List for now * removed tests for Primitive List for now * Primitive List feature(Part5: Element type check in annotation processor) (#5168) * @NotNull as alias for @required (#5161) This PR adds support for org.jetbrains.annotations.NotNull as an alias for @required. This means that Realm now understands the Kotlin type-system in the Realm schema. Previously we reported an error if you did @required RealmList<MyType> list = new RealmList<>();. It is a bit unclear why, since a RealmList is always non-null on managed objects. Since it made the interop with Kotlin kinda strange, I made a change so you can now do @required RealmList<MyType> list = new RealmLis<>() as well as val list : RealmList<MyType> = RealmList(); After this change it is no longer possible to do val person : Person either, you have to do val person : Person?. This reflects the constraints of Realm, but if people are able to maintain the variant themselves (hint: not possible when using sync), then they can use a custom non-null getter. * implement elemenrt type check of RealmList * fix error message * remove extra line * fix typo * address review comments
zaki50
added a commit
that referenced
this pull request
Sep 5, 2017
…sts) (#5151) * solve compilation errors related to Primitive List API changes * revert test * fix FB warnings * fix failing tests * Primitive List feature(Part4: Tests) (#5152) * Add Primitive List fields to test classes * removed tests for Primitive List for now * removed tests for Primitive List for now * Primitive List feature(Part5: Element type check in annotation processor) (#5168) * @NotNull as alias for @required (#5161) This PR adds support for org.jetbrains.annotations.NotNull as an alias for @required. This means that Realm now understands the Kotlin type-system in the Realm schema. Previously we reported an error if you did @required RealmList<MyType> list = new RealmList<>();. It is a bit unclear why, since a RealmList is always non-null on managed objects. Since it made the interop with Kotlin kinda strange, I made a change so you can now do @required RealmList<MyType> list = new RealmLis<>() as well as val list : RealmList<MyType> = RealmList(); After this change it is no longer possible to do val person : Person either, you have to do val person : Person?. This reflects the constraints of Realm, but if people are able to maintain the variant themselves (hint: not possible when using sync), then they can use a custom non-null getter. * implement elemenrt type check of RealmList * fix error message * remove extra line * fix typo * address review comments
zaki50
added a commit
that referenced
this pull request
Sep 5, 2017
* Nullability changes for Primitive List support * more @nullable annotations * fix annotation order * Primitive List feature(Part3: Temporary fix of implementations and tests) (#5151) * solve compilation errors related to Primitive List API changes * revert test * fix FB warnings * fix failing tests * Primitive List feature(Part4: Tests) (#5152) * Add Primitive List fields to test classes * removed tests for Primitive List for now * removed tests for Primitive List for now * Primitive List feature(Part5: Element type check in annotation processor) (#5168) * @NotNull as alias for @required (#5161) This PR adds support for org.jetbrains.annotations.NotNull as an alias for @required. This means that Realm now understands the Kotlin type-system in the Realm schema. Previously we reported an error if you did @required RealmList<MyType> list = new RealmList<>();. It is a bit unclear why, since a RealmList is always non-null on managed objects. Since it made the interop with Kotlin kinda strange, I made a change so you can now do @required RealmList<MyType> list = new RealmLis<>() as well as val list : RealmList<MyType> = RealmList(); After this change it is no longer possible to do val person : Person either, you have to do val person : Person?. This reflects the constraints of Realm, but if people are able to maintain the variant themselves (hint: not possible when using sync), then they can use a custom non-null getter. * implement elemenrt type check of RealmList * fix error message * remove extra line * fix typo * address review comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
org.jetbrains.annotations.NotNullas an alias for@Required. This means that Realm now understands the Kotlin type-system in the Realm schema.Previously we reported an error if you did
@Required RealmList<MyType> list = new RealmList<>();. It is a bit unclear why, since a RealmList is always non-null on managed objects. Since it made the interop with Kotlin kinda strange, I made a change so you can now do@Required RealmList<MyType> list = new RealmLis<>()as well asval list : RealmList<MyType> = RealmList();After this change it is no longer possible to do
val person : Personeither, you have to doval person : Person?. This reflects the constraints of Realm, but if people are able to maintain the variant themselves (hint: not possible when using sync), then they can use a custom non-null getter.