Fix Stackoverflow on RealmAny toString #7479
Open
+99
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aining a cycle through a RealmAny field
clementetb
commented
May 20, 2021
| // if a Realm object don't print the contents as it might end in a cycle. | ||
| String tableName = realmAny.asRealmModel(DynamicRealmObject.class).proxyState.getRow$realm().getTable().getClassName(); | ||
| long objectKey = realmAny.asRealmModel(DynamicRealmObject.class).proxyState.getRow$realm().getObjectKey(); | ||
| sb.append(String.format(Locale.US, "RealmAny<%s>(id:%d)", tableName, objectKey)); |
There was a problem hiding this comment.
@cmelchior , I thought it would be useful to print the object key for discerning between object instances, but not sure if it will confuse users to expose it, ideally we would be showing the PK. What do you think?
There was a problem hiding this comment.
It is probably fine to just show the ObjKey. It is a bit more secret, but easily available. Also, some objects might not have primary keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes StackOverflow when converting to string a DynamicRealmObject containing a cycle through a RealmAny field.