Test failures now report the real failure location #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of test failures, a TestFailureError object is thrown, which removes the last two stack frames so the true source of the failure is revealed to the native code. Clicking on a failure in the Xcode sidebar will take you to exactly where it occurred now. Fixes #28
|
|
||
| // Remove the top two stack frames if possible. | ||
| var stack = error.stack && error.stack.split('\n'); | ||
| var match = stack[2] && stack[2].match(/^(?:.*?@)?([^\[\(].+?):(\d+)(?::(\d+))?/); |
There was a problem hiding this comment.
Some comments here on what you are matching would be helpful - maybe put an example message in the comments.
|
Once you add a comment for the regex 👍 |
appden
added a commit
that referenced
this pull request
Sep 29, 2015
Test failures now report the real failure location
alazier
added a commit
that referenced
this pull request
Jan 19, 2016
Outstanding ObjectStore changes from the JS branch
alazier
pushed a commit
that referenced
this pull request
Sep 14, 2016
Update sync client API usage for session-specific auth
Closed
This was referenced Mar 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of test failures, a TestFailureError object is thrown, which removes the last two stack frames so the true source of the failure is revealed to the native code.
Clicking on a failure in the Xcode sidebar will take you to exactly where it occurred now.
Fixes #28