Basic data migrations #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alazier
force-pushed
the
al-migration
branch
2 times, most recently
from
869174c
to
8f07cd8
Compare
|
@appden ready for review now. |
| @@ -243,11 +245,12 @@ inline typename T::Function Realm<T>::create_constructor(ContextType ctx) { | |||
| } | |||
|
|
|||
| template<typename T> | |||
| void Realm<T>::constructor(ContextType ctx, ObjectType this_object, size_t argc, const ValueType arguments[]) { | |||
| void Realm<T>::constructor(ContextType ctx, ObjectType this_object, size_t argc, const ValueType arguments[]) { | |||
There was a problem hiding this comment.
Accidental whitespace added
| @@ -363,6 +378,12 @@ void Realm<T>::get_schema_version(ContextType ctx, ObjectType object, ReturnValu | |||
| } | |||
|
|
|||
| template<typename T> | |||
| void Realm<T>::get_schema(ContextType ctx, ObjectType object, ReturnValue &return_value) { | |||
| auto schema = get_internal<T, RealmClass<T>>(object)->get()->config().schema.get(); | |||
There was a problem hiding this comment.
It doesn't really matter, but I don't think the ->get() part is necessary.
There was a problem hiding this comment.
I get it now, since it's a pointer to a shared_ptr
|
|
||
| static const String type_string = "type"; | ||
| const std::string type = property.type != PropertyTypeArray ? string_for_property_type(property.type) : "list"; | ||
| Object::set_property(ctx, object, type_string, Value::from_string(ctx, type)); |
There was a problem hiding this comment.
I would prefer if the type be the objectType for type == "object", since we encourage that usage in our documentation to avoid confusion caused by objectType meaning two possible things.
There was a problem hiding this comment.
This makes code that is evaluating the schema much nastier - what you suggest would make it very difficult to check if something is an object type.
|
Looks good 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #333
Allows manual copying/renaming of properties without having to do an extra migrations. Design also supports stepwise migrations.
I think we should consider shipping this improvement without full support for property renames or schema access during migrations, as this eliminates the biggest pain points and current limitations.