Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immediately bind Realm in RealmProvider #5074

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Conversation

takameyer
Copy link
Contributor

@takameyer takameyer commented Nov 4, 2022

What, How & Why?

There was a possible optimisation pointed out by issue #5011 For local realm, we could just immediately open a new realm instance if the sync configuration is not set. This would skip the fallback procedure. It also fixes the jest warning the user was seeing.

As a side effect, I had to disable the fallback tests for the RealmProvider. We will have to start testing @realm/react with sync enabled in order to see this. I wrote an issue to get this done, so that we can also test authentication (#5073).

This closes #5011

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated

There was a possible optimisation pointed out by issue #5011
For local realm, we could just immediately open a new realm instance
if the sync configuration is not set.  This would skip the fallback
procedure.  It also fixes the jest warning the user was seeing.
@takameyer takameyer merged commit 881a3ec into master Nov 10, 2022
@takameyer takameyer deleted the andrew/rr-immediate-realm branch November 10, 2022 12:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants