Immediately bind Realm in RealmProvider #5074
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
There was a possible optimisation pointed out by issue #5011 For local realm, we could just immediately open a new realm instance if the sync configuration is not set. This would skip the fallback procedure. It also fixes the jest warning the user was seeing.
As a side effect, I had to disable the
fallback
tests for theRealmProvider
. We will have to start testing@realm/react
with sync enabled in order to see this. I wrote an issue to get this done, so that we can also test authentication (#5073).This closes #5011
☑️ ToDos
Compatibility
label is updated or copied from previous entryCOMPATIBILITY.md
package.json
s (if updating internal packages)Breaking
label has been applied or is not necessaryIf this PR adds or changes public API's: