Improve install tests (setting newArchEnabled and hermesEnabled correctly on Android)
#5375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out the local.properties are not read when building the app.
kraenhansen
commented
Feb 6, 2023
Comment on lines
+191
to
+198
| const localPropertiesContent = | ||
| "\n# Install test overwrites below\n\n" + | ||
| Object.entries(localProperties) | ||
| .map(([k, v]) => `${k}=${v}`) | ||
| .join("\n"); | ||
|
|
||
| console.log(`Writing local.properties to ${localPropertiesPath}`); | ||
| fs.writeFileSync(localPropertiesPath, localPropertiesContent); | ||
| console.log(`Appending gradle properties to ${localPropertiesPath}`); | ||
| fs.appendFileSync(localPropertiesPath, localPropertiesContent); |
There was a problem hiding this comment.
This fixes configuring hermes and new architecture on Android.
kraenhansen
commented
Feb 6, 2023
| @@ -18,6 +18,7 @@ defaults: | |||
|
|
|||
| jobs: | |||
| install: | |||
| name: Install Test on React Native ${{ matrix.platform == 'ios' && 'iOS' || 'Android' }} realm@${{ matrix.realm-version }}, react-native@${{ matrix.react-native-version }} new architecture ${{ matrix.new-architecture && 'enabled' || 'disabled' }} running ${{ matrix.engine }} | |||
There was a problem hiding this comment.
Making the name of the job a bit more readable:
kraenhansen
changed the title
newArchEnabled and hermesEnabled correctly on Android)
takameyer
reviewed
Feb 7, 2023
| // Read the persons out of the database again | ||
| const message = | ||
| "Persons are " + | ||
| realm | ||
| .objects("Person") | ||
| .map((p) => p.name) | ||
| .join(", "); | ||
| .join(", ") + | ||
| suffix; |
There was a problem hiding this comment.
If i'm understanding this right, this will output a "!" when successful? Is that meaningful?
There was a problem hiding this comment.
Is that meaningful?
Not really 🙂 I just need some string to round-trip and expect.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
We had a bug in the way the install tests configured the Android test to run with Hermes disabled.
Also, we now test throwing in code called from C++, because that has historically been (and is currently) broken (because of facebook/react-native#36052).
This also makes it so PRs updating the install test workflow won't post and spam the team channel anymore.