Add support for sync proxy (node.js only) #5914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
reviewed
Jun 21, 2023
kraenhansen
reviewed
Jun 21, 2023
kraenhansen
reviewed
Jun 21, 2023
elle-j
reviewed
Jun 21, 2023
takameyer
approved these changes
Jun 23, 2023
|
@takameyer asks
I haven't found a polyfill for |
takameyer
reviewed
Jun 26, 2023
|
|
||
| import { inject } from "../sync-proxy-config"; | ||
|
|
||
| // simply returning `undefined` to signal that proxy settings should be silently ignored. |
There was a problem hiding this comment.
Should we silently be ignoring this? I would like some sort of signal if I were trying to implementing this
There was a problem hiding this comment.
I would prefer to silently ignore it - and provide the proper fix by moving to platform networking when we have the time.
takameyer
reviewed
Jun 26, 2023
| @@ -18,5 +18,6 @@ | |||
|
|
|||
| import "./fs"; | |||
| import "./device-info"; | |||
| import "./sync-proxy-config"; | |||
There was a problem hiding this comment.
Should this be done in react-native as well?
There was a problem hiding this comment.
Alternatively, we could just remove the react-native implementation and let it throw.
takameyer
reviewed
Jun 26, 2023
kneth
force-pushed
the
kneth/http-proxy
branch
2 times, most recently
from
0fc56b7
to
bec0639
Compare
Co-authored-by: LJ <81748770+elle-j@users.noreply.github.com>
Co-authored-by: LJ <81748770+elle-j@users.noreply.github.com>
Co-authored-by: LJ <81748770+elle-j@users.noreply.github.com>
Co-authored-by: LJ <81748770+elle-j@users.noreply.github.com>
Co-authored-by: Andrew Meyer <andrew.meyer@mongodb.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This closes #5816
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: