Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Our
bindgen:generate:typescript
andbindgen:generate:wrappers
scripts rely on therealm-bindgen
command. For Bindgen's node dependencies in Core to be installed correctly and allow for therealm-bindgen
command to be run,npm install
needs to be run aftergit submodule update --init --recursive
(which was previously in ourpostinstall
script).Replacing the
postinstall
with apreinstall
does not fix this issue.This PR removes the
postinstall
script all together, moving the responsibility of fetching the submodule to the developer:☑️ ToDos
--