-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Airbnb Demo #6725
Add Airbnb Demo #6725
Conversation
This demo was created to demonstrate how Realm can be used as a cache for search results. It also shows various statistics in terms of disk usage and how much space the cache is using.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The app works for me now but I needed to adjust the search index's name capitalization, after that change should be all good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[wip] First pass 🙂
Co-authored-by: LJ <81748770+elle-j@users.noreply.github.com>
457db70
to
2a2c286
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[wip]
examples/rn-mbnb/.prettierrc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to also enforce some linting consistency like e.g.:
"
vs'
{someName}
vs{ someName }
- Trailing commas
- End with
;
Perhaps we can extend some recommended configs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probable that I never ran proper prettier/linting over this code.
Is the issue that the formatting differs from the other examples? Most probable it is because Expo comes with its own defaults.
I think generally just using the default of whatever platform is being used would be fine. Development teams will generally override this at some point anyway. If our example code hasn't applied the linting/prettier rules though, we should update that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having some things differ from the other examples is fine from my point of view, it's mainly that it'd be good to keep it consistent within the project itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome Andrew! 🥳 Thank you so much for adding this, definitely an interesting and helpful use case to have!
Co-authored-by: LJ <81748770+elle-j@users.noreply.github.com>
What, How & Why?
This demo was created to demonstrate how Realm can be used as a cache for search results. It also shows various statistics in terms of disk usage and how much space the cache is using.
☑️ ToDos
Compatibility
label is updated or copied from previous entryCOMPATIBILITY.md
package.json
s (if updating internal packages)Breaking
label has been applied or is not necessary