This repository has been archived by the owner on Mar 2, 2023. It is now read-only.
use _inform_error() to make error handling more coherent #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
reviewed
Sep 12, 2022
JacobOscarGunnarsson
force-pushed
the
jg/fix-error-handling
branch
from
453520d
to
3382286
Compare
fealebenpae
suggested changes
Sep 12, 2022
JacobOscarGunnarsson
force-pushed
the
jg/fix-error-handling
branch
from
3382286
to
4029023
Compare
elle-j
reviewed
Sep 12, 2022
JacobOscarGunnarsson
force-pushed
the
jg/fix-error-handling
branch
from
4029023
to
8dbe99a
Compare
elle-j
approved these changes
Sep 13, 2022
# Conflicts: # src/realm_native_lib.cpp
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will essentially make it easier for us to follow a standard. We also get extra information such as what line the error occurred at.