Eliminate a redundant call to RLMRealmSetSchemaAndAlign when migrations occur #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns occur It's not idempotent, so the extra call actively broke things when migrations ran.
|
👍 |
|
This does look like a more proper fix. 👍 |
tgoyne
added a commit
that referenced
this pull request
Jul 2, 2015
Eliminate a redundant call to RLMRealmSetSchemaAndAlign when migrations occur
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a slightly more correct version of #2109. This still doesn't fix the root problem of that a lot of ridiculous things are done with the schema in the migrations codepath, but it at least avoids doing the specific bad thing that causes breakage (call RLMRealmSetSchemaAndAlign() on a single target schema multiple times) rather than trying to clean up afterwards.