-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for the app services split branch #8539
Conversation
bab3dfd
to
04d58ce
Compare
1f375ce
to
2ea8d98
Compare
2ea8d98
to
6520318
Compare
@@ -334,16 +330,16 @@ - (instancetype)initWithApp:(std::shared_ptr<realm::app::App>&&)app config:(RLMA | |||
- (instancetype)initWithConfiguration:(RLMAppConfiguration *)configuration { | |||
if (self = [super init]) { | |||
_app = RLMTranslateError([&] { | |||
return app::App::get_app(app::App::CacheMode::Enabled, configuration.config, configuration.clientConfig); | |||
return app::App::get_app(app::App::CacheMode::Disabled, configuration.config); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we disabling the caching here? Is it because we're anyway maintaining an SDK-level cache?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we never actually get a cache hit in the core cache unless something has gone wrong.
@see `RLMSyncErrorClientResetError`, `RLMSyncErrorPermissionDeniedError` | ||
|
||
@see ```RLMSyncErrorClientResetError``, ``RLMSyncErrorPermissionDeniedError`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we have an extra backtick here
@see ```RLMSyncErrorClientResetError``, ``RLMSyncErrorPermissionDeniedError`` | |
@see ``RLMSyncErrorClientResetError``, ``RLMSyncErrorPermissionDeniedError`` |
realm/realm-core#7300