This repository has been archived by the owner on Jan 11, 2019. It is now read-only.
Fix several permissions issues #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naked object server URL w/out the actual realm name (e.g., "realm://138.197.85.79:9080" versus "realm://138.197.85.79/global"). This may have expose a rather large bug on the JS side of the object server (filed as https://github.com/realm/realm-object-server/issues/926) - Added a permission change notifier to track the permission changes - Moved the try block to only surrout the actual permission change call to the management realm
TimOliver
approved these changes
Feb 10, 2017
|
closing this - already handled by another update to master by @bigfish24 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed error in URL in permission change request - was using the naked object server URL w/out the actual realm name (e.g.,
"realm://138.197.85.79:9080" versus "realm://138.197.85.79/global").
Side note: This may have exposed a bug on the object server (filed as https://github.com/realm/realm-object-server/issues/926)
Added a permission change notifier to track the permission changes and log them to the console
Moved the try block to only surround the actual permission change call to the management realm rather than hate creation of the change object and permission change notifier