This repository has been archived by the owner on Jan 11, 2019. It is now read-only.
Minor model cleanup #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhmspector
reviewed
Oct 26, 2017
There was a problem hiding this comment.
Looks fine to me, but we need to merge only after coordination with Ian to make sure we don't conflict with his customer activities.
Several of these changes may have impact on his javascript back end
@ianpward What's your demo schedule? Also: NB: these changes will force a rebuild of the apps and wiping/recreation of installed databased since the model changes are destructive.
ianpward
reviewed
Oct 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just general cleanup of minor issues I hit into while working with Chat.