Changing a named reference constraint crashes FreeCAD #387
Labels
Comments
|
I can't reproduce it. How do you change the length using mouse? By dragging the line? Also, did it freeze or crash? If it crashes, please start the AppImage using command line in a terminal, and post the call stack dump when it crashes? If it freezes, please find out the running FreeCADLink process ID. You can use the task manager on your system. And then kill the process by typing the following command in a terminal, and post the dump here. kill -SIGSEGV <ProcessID> |
|
Sorry for the wrong term, it freezes FreeCAD it doesn't crashing it. And next is the same procedure with the only difference being that I press OK button without marking the constraint as reference and then reopen it again and making it reference. This doesn't freezes the app. I killed FreeCAD with -SIGSEGV but I have no idea where core is dumped (is not on the working directory), I can imagine that AppImages are dropping dumps in their "virtual space" or something? This is the console output |
realthunder
added a commit
to realthunder/FreeCAD
that referenced
this issue
Dec 23, 2020
realthunder
added a commit
to realthunder/FreeCAD
that referenced
this issue
Dec 23, 2020
realthunder
added a commit
to realthunder/FreeCAD
that referenced
this issue
Dec 23, 2020
abdullahtahiriyo
added a commit
to abdullahtahiriyo/FreeCAD_sf_master
that referenced
this issue
Dec 24, 2020
======================================== Report: FreeCAD#4183 realthunder/FreeCAD_assembly3#387 Problem: renameConstraint() previously implemented exclusively in SketchObjectPyImp.cpp, will change the Constraints property without updating the solver. A prospective drag operation would rely on a deleted pointer constraint which leads to the crash. Solution: make renameConstraint function update the solver so that Bonus: move the core of the function to SketchObject.cpp so that input data validity check on constraint change is inhibited.
abdullahtahiriyo
added a commit
to abdullahtahiriyo/FreeCAD_sf_master
that referenced
this issue
Dec 27, 2020
======================================== Report: FreeCAD#4183 realthunder/FreeCAD_assembly3#387 Problem: renameConstraint() previously implemented exclusively in SketchObjectPyImp.cpp, will change the Constraints property without updating the solver. A prospective drag operation would rely on a deleted pointer constraint which leads to the crash. Solution: make renameConstraint function update the solver so that Bonus: move the core of the function to SketchObject.cpp so that input data validity check on constraint change is inhibited.
abdullahtahiriyo
added a commit
to abdullahtahiriyo/FreeCAD_sf_master
that referenced
this issue
Dec 27, 2020
======================================== Report: FreeCAD#4183 realthunder/FreeCAD_assembly3#387 Problem: renameConstraint() previously implemented exclusively in SketchObjectPyImp.cpp, will change the Constraints property without updating the solver. A prospective drag operation would rely on a deleted pointer constraint which leads to the crash. Solution: make renameConstraint function update the solver so that Bonus: move the core of the function to SketchObject.cpp so that input data validity check on constraint change is inhibited.
abdullahtahiriyo
added a commit
to abdullahtahiriyo/FreeCAD_sf_master
that referenced
this issue
Dec 27, 2020
======================================== Report: FreeCAD#4183 realthunder/FreeCAD_assembly3#387 Problem: renameConstraint() previously implemented exclusively in SketchObjectPyImp.cpp, will change the Constraints property without updating the solver. A prospective drag operation would rely on a deleted pointer constraint which leads to the crash. Solution: - mark the solver status as needing an update - leverage new through sketchobject r/w interface to ensure solver is synchronised before the temporary move operation starts Bonus: move the core of the function to SketchObject.cpp so that input data validity check on constraint change is inhibited.
abdullahtahiriyo
added a commit
to abdullahtahiriyo/FreeCAD_sf_master
that referenced
this issue
Dec 27, 2020
======================================== Report: FreeCAD#4183 realthunder/FreeCAD_assembly3#387 Problem: renameConstraint() previously implemented exclusively in SketchObjectPyImp.cpp, will change the Constraints property without updating the solver. A prospective drag operation would rely on a deleted pointer constraint which leads to the crash. Solution: - mark the solver status as needing an update - leverage new through sketchobject r/w interface to ensure solver is synchronised before the temporary move operation starts Bonus: move the core of the function to SketchObject.cpp so that input data validity check on constraint change is inhibited.
abdullahtahiriyo
added a commit
to abdullahtahiriyo/FreeCAD_sf_master
that referenced
this issue
Dec 27, 2020
======================================== Report: FreeCAD#4183 realthunder/FreeCAD_assembly3#387 Problem: renameConstraint() previously implemented exclusively in SketchObjectPyImp.cpp, will change the Constraints property without updating the solver. A prospective drag operation would rely on a deleted pointer constraint which leads to the crash. Solution: - mark the solver status as needing an update - leverage new through sketchobject r/w interface to ensure solver is synchronised before the temporary move operation starts Bonus: move the core of the function to SketchObject.cpp so that input data validity check on constraint change is inhibited.
abdullahtahiriyo
added a commit
to abdullahtahiriyo/FreeCAD_sf_master
that referenced
this issue
Dec 27, 2020
======================================== Report: FreeCAD#4183 realthunder/FreeCAD_assembly3#387 Problem: renameConstraint() previously implemented exclusively in SketchObjectPyImp.cpp, will change the Constraints property without updating the solver. A prospective drag operation would rely on a deleted pointer constraint which leads to the crash. Solution: - mark the solver status as needing an update - leverage new through sketchobject r/w interface to ensure solver is synchronised before the temporary move operation starts Bonus: move the core of the function to SketchObject.cpp so that input data validity check on constraint change is inhibited.
abdullahtahiriyo
added a commit
to abdullahtahiriyo/FreeCAD_sf_master
that referenced
this issue
Dec 27, 2020
======================================== Report: FreeCAD#4183 realthunder/FreeCAD_assembly3#387 Problem: renameConstraint() previously implemented exclusively in SketchObjectPyImp.cpp, will change the Constraints property without updating the solver. A prospective drag operation would rely on a deleted pointer constraint which leads to the crash. Solution: - mark the solver status as needing an update - leverage new through sketchobject r/w interface to ensure solver is synchronised before the temporary move operation starts Bonus: move the core of the function to SketchObject.cpp so that input data validity check on constraint change is inhibited.
abdullahtahiriyo
added a commit
to FreeCAD/FreeCAD
that referenced
this issue
Dec 27, 2020
======================================== Report: #4183 realthunder/FreeCAD_assembly3#387 Problem: renameConstraint() previously implemented exclusively in SketchObjectPyImp.cpp, will change the Constraints property without updating the solver. A prospective drag operation would rely on a deleted pointer constraint which leads to the crash. Solution: - mark the solver status as needing an update - leverage new through sketchobject r/w interface to ensure solver is synchronised before the temporary move operation starts Bonus: move the core of the function to SketchObject.cpp so that input data validity check on constraint change is inhibited.
|
Tested on: OS: Windows 10 Version 2009 No issue found. |
|
Closing ticket |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I can constantly recreate this issue following this procedure.
If the constraint is unnamed there is no problem
Tried to recreate this in the "official" 0.19 AppImage and doesn't crashes
I run the following version:
The text was updated successfully, but these errors were encountered: