Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(commitlint): addition of commit message linter #665

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

tiborsimko
Copy link
Member

@tiborsimko tiborsimko commented Jan 10, 2024

Adds commitlint to check the commit message style against agreed
conventional commits configuration.

Changes script argument values to always use linter names (e.g.
shellcheck).

Changes argument handling to allow only one checking action that can now
accept further optional arguments.

@tiborsimko tiborsimko changed the title Commitlint ci(commitlint): addition of commit message linter Jan 10, 2024
tiborsimko added a commit to tiborsimko/reana-server that referenced this pull request Jan 10, 2024
Adds commitlint to check the commit message style against agreed
conventional commits configuration.

Changes script argument values to always use linter names (e.g.
shellcheck).

Changes argument handling to allow only one checking action that can now
accept further optional arguments.
tiborsimko added a commit to tiborsimko/reana-server that referenced this pull request Jan 10, 2024
tiborsimko added a commit to tiborsimko/reana-server that referenced this pull request Jan 10, 2024
Adds commitlint to check the commit message style against agreed
conventional commits configuration.

Changes script argument values to always use linter names (e.g.
shellcheck).

Changes argument handling to allow only one checking action that can now
accept further optional arguments.
Pins `invenio-userprofiles` dependency to (at most) 1.2.4 version since
the upstream 1.2.5 version changed the import-related code in a way that
started to break the `reana-server` build.
@tiborsimko tiborsimko marked this pull request as ready for review January 12, 2024 13:04
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (426e8a2) 59.46% compared to head (d6cb168) 59.46%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #665   +/-   ##
=======================================
  Coverage   59.46%   59.46%           
=======================================
  Files          32       32           
  Lines        3298     3298           
=======================================
  Hits         1961     1961           
  Misses       1337     1337           

@tiborsimko tiborsimko merged commit d6cb168 into reanahub:master Jan 12, 2024
14 checks passed
@tiborsimko tiborsimko deleted the commitlint branch January 12, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants