-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(commitlint): addition of commit message linter #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborsimko
changed the title
Commitlint
ci(commitlint): addition of commit message linter
Jan 10, 2024
tiborsimko
added a commit
to tiborsimko/reana-server
that referenced
this pull request
Jan 10, 2024
Adds commitlint to check the commit message style against agreed conventional commits configuration. Changes script argument values to always use linter names (e.g. shellcheck). Changes argument handling to allow only one checking action that can now accept further optional arguments.
tiborsimko
added a commit
to tiborsimko/reana-server
that referenced
this pull request
Jan 10, 2024
tiborsimko
force-pushed
the
commitlint
branch
from
January 10, 2024 13:23
837230d
to
c46ee04
Compare
tiborsimko
added a commit
to tiborsimko/reana-server
that referenced
this pull request
Jan 10, 2024
tiborsimko
force-pushed
the
commitlint
branch
from
January 10, 2024 13:38
c46ee04
to
0ca40ea
Compare
Adds commitlint to check the commit message style against agreed conventional commits configuration. Changes script argument values to always use linter names (e.g. shellcheck). Changes argument handling to allow only one checking action that can now accept further optional arguments.
tiborsimko
force-pushed
the
commitlint
branch
from
January 11, 2024 16:44
0ca40ea
to
1d5e7c5
Compare
Pins `invenio-userprofiles` dependency to (at most) 1.2.4 version since the upstream 1.2.5 version changed the import-related code in a way that started to break the `reana-server` build.
This was referenced Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds commitlint to check the commit message style against agreed
conventional commits configuration.
Changes script argument values to always use linter names (e.g.
shellcheck).
Changes argument handling to allow only one checking action that can now
accept further optional arguments.