Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property Licensing Data #8948

Closed
Speedway1 opened this issue Apr 27, 2023 · 11 comments
Closed

Property Licensing Data #8948

Speedway1 opened this issue Apr 27, 2023 · 11 comments
Assignees
Labels
8 8 story points added-late An issue that was added to sprint after it began agency-cloud Relates to Agency Cloud back-end Relates to back end issues external-request External request feature New feature or request feature-request User requested feature

Comments

@Speedway1
Copy link

Speedway1 commented Apr 27, 2023

H support,

We need to gain access to the attributes on the licensing screen. These are available through the "extra" field. Please can you enable access for the SBOX and SAU accounts. Please be aware that there is a customer entering UAT who will need this turned on fairly sharpish too. support@sms-speedway.com can confirm the details.

Specification

  • Project: Reapit.Services.Properties
  • Add new PropertyLettingLicensingModel as follows that exposes the semi structured fields set by AgencyCloud
"licensing": {
	"licenseRequired": bool,
	"licenseTypeId": "string" // Confirm whether or not this list is customisable. If it is not, name it licenseType and create an enum with the values
	"households": int,
	"occupants": int, 
	"aboveCommercialPremises": bool,
	"application": {
		"status": "string" // Is this list configurable
		"referenceNumber": "string",
		"date": "date" [ShortDate]
		"granted": "date" [ShortDate]
		"expiry": "date" [ShortDate]
	},
}
- If the licenseType is a configurable list, we will need to add link in PropertyModel to a new endpoint that will need to be added to the configuration API for exposing this list (do as part of this ticket if it is needed)

- Add new `UpdatePropertyLettingLicensingModel` as above that allows the values to be updated with the following validation rules:
  - Households and Occupants >= 0 when set
  - Application granted/expiry dates cannot be prior to the application date
  - Application expiry date cannot be prior to the granted date
  - Application status should be a valid enum value (UNLESS this is a configurable list in which case we should validate against the list which can be looked up from the configuration service)
  - LicenseType be a valid enum value (UNLESS this is a configurable list in which case we should validate against the list which can be looked up from the configuration service)
@Speedway1 Speedway1 added back-end Relates to back end issues feature New feature or request labels Apr 27, 2023
@AshDeeming AshDeeming added feature-request User requested feature external-request External request labels Apr 27, 2023
@plittlewood-rpt
Copy link
Contributor

Hi @Speedway1 we are currently just scoping out the work to add proper support for Property Licensing. I'll update this ticket and attach it to the relevant milestone once the various items have been logged

@plittlewood-rpt
Copy link
Contributor

This is waiting for the desktop team to look at refactoring this mechanism slightly. We will revisit this once they have agreed on the route forwards

@plittlewood-rpt plittlewood-rpt changed the title Expose "extra" field for SBOX and SAU accounts Property Licensing Data May 30, 2023
@plittlewood-rpt plittlewood-rpt added the agency-cloud Relates to Agency Cloud label May 30, 2023
@github-actions
Copy link
Contributor

As this issue relates to AgencyCloud, we are unable to process this through the Platform in accordance with our Developer Processes.
Issues relating to AgencyCloud should not be submitted via the Foundations GitHub repo but should be raised via the Reapit Service Desk by a Reapit Customer.
Please ask a Reapit Customer to raise this issue via the Reapit Service Desk.
For more information on our processes, please click here

@plittlewood-rpt plittlewood-rpt added the 8 8 story points label Jun 28, 2023
@github-actions
Copy link
Contributor

This issue has been updated and moved to our ‘Near Term’ column (typically completed within 0 - 4 months). We have assessed the effort required and outlined a technical specification - please take the time to review this detail. When we're ready to schedule the issue, it will be assigned to the relevant board where you can continue to track its progress to completion.
For more information on our processes, please click here

@RLAV1
Copy link

RLAV1 commented Jul 4, 2023

Savills have confirmed this is urgent to be completed and if we have a timeframe or eta on completion?

@plittlewood-rpt plittlewood-rpt added the added-late An issue that was added to sprint after it began label Jul 6, 2023
@ashindey12 ashindey12 self-assigned this Jul 7, 2023
@RLAV1
Copy link

RLAV1 commented Jul 11, 2023

Hey @HollyJoyPhillips FYI
This one is required by Savills as early as possible

@github-actions
Copy link
Contributor

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference.
For more information on our processes, please click here

@au63
Copy link

au63 commented Jul 13, 2023

I am seeing that this is closed but may I know where in the documentation can I see the details for licencing api?

@github-actions
Copy link
Contributor

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference.
For more information on our processes, please click here

@plittlewood-rpt
Copy link
Contributor

Hi @au63 please refer to the specification on this ticket. It's a new object property.letting.licencing

Thanks
Pete

@github-actions
Copy link
Contributor

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference.
For more information on our processes, please click here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8 8 story points added-late An issue that was added to sprint after it began agency-cloud Relates to Agency Cloud back-end Relates to back end issues external-request External request feature New feature or request feature-request User requested feature
Projects
None yet
Development

No branches or pull requests

6 participants