Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #639: unused variable in website example #640

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

josdejong
Copy link
Contributor

@josdejong josdejong commented Dec 22, 2020

Fixes #639 .

I've changed "Hello!" to "Hello " ++ name and not "Hello " ++ name ++ "!" in order to keep the example as minimal as possible.

I'm not entirely sure whether I fixed the example in the right place, (in the source, and not in some generated output), please double check.

@davesnx
Copy link
Member

davesnx commented Nov 23, 2022

Thanks @josdejong

@davesnx davesnx merged commit 7374614 into reasonml:master Nov 23, 2022
@josdejong josdejong deleted the fix/639_website_example branch November 24, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimal example on ReasonReact website has an unused variable "name"
2 participants