Fix 2695: local open + let bindings #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
reviewed
Apr 24, 2023
| @@ -6442,7 +6442,12 @@ let printer = object(self:'self) | |||
| (atom ("."))) | |||
| (self#formatNonSequencyExpression e)) | |||
| else | |||
| Some (makeLetSequence (self#letList x)) | |||
| Some | |||
There was a problem hiding this comment.
this looks exactly like the then branch.
I'm surprised this doesn't break let open Foo; bar; for example?
Perhaps the letop case should be added to isSeriesOfOpensFollowedByNonSequencyExpression, then we'd get printing for free?
There was a problem hiding this comment.
Well, not exactly the same. The first branch results into extra braces:
- let* x = Js.Promise.resolve(42);
- Js.Promise.resolve(x * 2);
+ {
+ let* x = Js.Promise.resolve(42);
+ Js.Promise.resolve(x * 2);
+ }
There was a problem hiding this comment.
I did make a small change to avoid code duplication
There was a problem hiding this comment.
I don't see how this is correct yet. I might be missing something.
Aren't we replacing ALL open calls with Foo.( ... )?
There was a problem hiding this comment.
Not exactly, but the solution wasn't perfect (it didn't work for nested local open modules). I've tried to improve on it with help of an extra attribute set by the parser.
SanderSpies
commented
May 1, 2023
anmonteiro
force-pushed
the
sanderspies/fix_2695
branch
from
e7308d4
to
722e1a6
Compare
|
Thank you again, and sorry for the delay |
anmonteiro
added a commit
to anmonteiro/opam-repository
that referenced
this pull request
Jul 23, 2024
CHANGES:
- Add `\u{hex-escape}` syntax (@anmonteiro,
[reasonml/reason#2738](reasonml/reason#2738))
- Support local open and let bindings (@SanderSpies) [reasonml/reason#2716](reasonml/reason#2716)
- outcome printer: change the printing of `@bs.*` to `@mel.*` (@anmonteiro, [reasonml/reason#2755](reasonml/reason#2755))
- Fix outcome printing of optional arguments on OCaml 5.2 (@anmonteiro, [reasonml/reason#2753](reasonml/reason#2753))
- support parsing and printing of `external%extension` (@anmonteiro, [reasonml/reason#2750](reasonml/reason#2750), [reasonml/reason#2766](reasonml/reason#2766), [reasonml/reason#2767](reasonml/reason#2767))
- install `refmt` manpage (@anmonteiro, [reasonml/reason#2760](reasonml/reason#2760))
- add support for parsing / printing of refutation clause in `switch` (@anmonteiro, [reasonml/reason#2765](reasonml/reason#2765))
- support `let%ppx` in signatures (@anmonteiro, [reasonml/reason#2770](reasonml/reason#2770))
avsm
pushed a commit
to avsm/opam-repository
that referenced
this pull request
Sep 5, 2024
CHANGES:
- Add `\u{hex-escape}` syntax (@anmonteiro,
[reasonml/reason#2738](reasonml/reason#2738))
- Support local open and let bindings (@SanderSpies) [reasonml/reason#2716](reasonml/reason#2716)
- outcome printer: change the printing of `@bs.*` to `@mel.*` (@anmonteiro, [reasonml/reason#2755](reasonml/reason#2755))
- Fix outcome printing of optional arguments on OCaml 5.2 (@anmonteiro, [reasonml/reason#2753](reasonml/reason#2753))
- support parsing and printing of `external%extension` (@anmonteiro, [reasonml/reason#2750](reasonml/reason#2750), [reasonml/reason#2766](reasonml/reason#2766), [reasonml/reason#2767](reasonml/reason#2767))
- install `refmt` manpage (@anmonteiro, [reasonml/reason#2760](reasonml/reason#2760))
- add support for parsing / printing of refutation clause in `switch` (@anmonteiro, [reasonml/reason#2765](reasonml/reason#2765))
- support `let%ppx` in signatures (@anmonteiro, [reasonml/reason#2770](reasonml/reason#2770))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2695.
Makes it possible to use:
Printing isn't perfect, but good enough for now.