Skip to content
This repository has been archived by the owner on Apr 14, 2024. It is now read-only.

Fix body scroll lock on iOS #12

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Fix body scroll lock on iOS #12

merged 3 commits into from
Mar 12, 2024

Conversation

ghsteff
Copy link
Contributor

@ghsteff ghsteff commented Mar 11, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Global overlay child content wasn't scrollable on iOS

What is the new behavior?

Global overlay child content can be scrolled in iOS by adding the html element attribute body-scroll-lock-ignore to the content

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This fixes an issue where all touchmove events on iOS were getting disabled within GlobalOverlays

Now attaching the attribute `body-scroll-lock-ignore` to an element will allow touchmove events on ios
@ghsteff ghsteff requested a review from amcdnl March 11, 2024 20:05
docs/components/Overlay.mdx Outdated Show resolved Hide resolved
@ghsteff
Copy link
Contributor Author

ghsteff commented Mar 11, 2024

I saw this issue with storybook. I tried some stuff in here real quick but still couldn't get it working: storybookjs/storybook#23338

it's why the build's failing

@amcdnl
Copy link
Member

amcdnl commented Mar 11, 2024

I saw this issue with storybook. I tried some stuff in here real quick but still couldn't get it working: storybookjs/storybook#23338

it's why the build's failing

Those preview errors are likely just the result of something else.

@amcdnl amcdnl merged commit 4bbeb83 into master Mar 12, 2024
1 check passed
@amcdnl amcdnl deleted the fix/body-scroll-lock-ios branch March 12, 2024 09:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants