Add Result Extraction Helpers #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandpeelen
force-pushed
the
result-extraction-helpers
branch
from
3135393
to
e17aabe
Compare
andywhite37
requested changes
Jan 8, 2021
src/Relude_Result.re
Outdated
| Result.getErrorOrElse("Handled", Ok({id, payload})) == "Handled"; | ||
| ]} | ||
| */ | ||
| let getErrorOrElse: 'e 'e. ('e, t('a, 'e)) => 'e = |
There was a problem hiding this comment.
Did you want the universal types to be 'a 'e. here?
There was a problem hiding this comment.
Good catch! not sure how those crept in. Fixed in next commit :)
andywhite37
approved these changes
Jan 8, 2021
There was a problem hiding this comment.
Looks great! Thanks for adding these. I'll give @mlms13 a chance to look, but I'm good to merge
mlms13
approved these changes
Jan 8, 2021
|
This looks great to me! Thanks for adding tests and all the doc comments as well!. |
|
No worries, thank you guys for putting in all the effort to build and maintain this! |
|
I can push out a new release this evening |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in: #285
This PR adds the following three functions:
Since these are a bit niche, the examples are a bit niche as well. Given the rest of the examples they might be a bit verbose. Please let me know if that's the case, then I'll try and make it less so.
The PR can be reviewed commit-by-commit.