This repository has been archived by the owner on May 12, 2018. It is now read-only.
Mock gpb and protobuffs, in inttest, replacing external dependencies #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... The build failure appears to be unrelated. |
|
Yeah, something appears to have changed on travis-ci. Related: http://www.erlang.org/pipermail/erlang-questions/2015-January/082344.html. |
|
This sounds sane to me. If Tuncer agrees or whatever, I'll just run the tests locally and see if it's mergeable until Travis fix their networks or we adapt our tests to it. |
|
+1 |
In inttest/proto_gpb, replace the external dependency to gpb, a protocol buffer compiler, with a simple mock. The mock provides enough of what is needed for inttest only, which is to generate some dummy content, but with proper file names. As a result, the increased timeout for the proto_gpb inttest should no longer be needed (inttest/proto_gpb/retest.config), both since the mock is now much faster to compile, and since any network bandwidth or connectivity issues have now been eliminated.
In inttest/proto_protobuffs, replace the external dependency to erlang_protobuffs, a protocol buffer compiler, with a simple mock. The mock provides enough of what is needed for inttest only, which is to generate some dummy content, but with proper file names.
tomas-abrahamsson
force-pushed
the
mock-gpb-and-protobuffs-in-inttest
branch
from
6ce3eb7
to
2af51af
Compare
|
Updated: fixed a superfluous empty line |
|
This appeared to work well for me too, local tests passed. Merging. |
ferd
added a commit
that referenced
this pull request
Jan 7, 2015
…s-in-inttest Mock gpb and protobuffs, in inttest, replacing external dependencies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen recently a few cases where the rebar build failed due to failure to retrieve external dependencies. The dependencies were to gpb and to protobuffs. This pull request replaces those external dependencies with mocks. As a results, the builds should be more stable and faster. The mocks turned out to be only a few lines of code. I believe these two external dependencies are the only such dependencies in the tests.
Those dependencies were introduced when #203 was merged, and evidence of build failures can be seen in the discussions in #413 and #419.