Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module directory to include path #1035

Merged
merged 1 commit into from
Jan 26, 2016

Conversation

lrascao
Copy link
Contributor

@lrascao lrascao commented Jan 26, 2016

Several projects use an include path relative
to the project's root.
file:compile will look in three places for the include
files:
The current working directory
The directory where the module is being compiled
The directories given by the include option

@ferd
Copy link
Collaborator

ferd commented Jan 26, 2016

We're gonna need a test with that to avoid accidental regressions. There's a basic explanation on how to write them in https://github.com/rebar/rebar3/blob/master/CONTRIBUTING.md#tests, but if you want some help, I can try to write something up at some point this week.

Otherwise the changes look good.

@lrascao
Copy link
Contributor Author

lrascao commented Jan 26, 2016

Sure, i'll try and get something done this week

Several projects use an include path relative
to the project's root.
file:compile will look in three places for the include
files:
The current working directory
The directory where the module is being compiled
The directories given by the include option
@lrascao
Copy link
Contributor Author

lrascao commented Jan 26, 2016

2 new tests added

@ferd
Copy link
Collaborator

ferd commented Jan 26, 2016

Sounds good, +1.

tsloughter added a commit that referenced this pull request Jan 26, 2016
@tsloughter tsloughter merged commit 964da8c into erlang:master Jan 26, 2016
@lrascao lrascao deleted the fix/missing_include_path branch January 26, 2016 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants