Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check top level config for minimum or blacklisted otps at start #1050

Merged
merged 1 commit into from
Feb 3, 2016
Merged

check top level config for minimum or blacklisted otps at start #1050

merged 1 commit into from
Feb 3, 2016

Conversation

tsloughter
Copy link
Collaborator

Fix for #871

@ferd
Copy link
Collaborator

ferd commented Feb 3, 2016

I'm a +1 on this, but does it really fix #871 where it may try to load a map in a runtime that doesn't support them for some config files?

@tsloughter
Copy link
Collaborator Author

It does fix #871 since that is where a map is in the .app. It isn't possible to run before reading in rebar.config, so can't guard against that but this is the earliest we can check so it is the best we can do.

ferd added a commit that referenced this pull request Feb 3, 2016
@ferd
Merge pull request #1050 from tsloughter/master
9e1abdb 
check top level config for minimum or blacklisted  otps at start
@ferd ferd merged commit 9e1abdb into erlang:master Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsloughter @ferd