Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete and prepend code path instead of replacing, fixes #770 #772

Merged
merged 1 commit into from
Sep 6, 2015
Merged

delete and prepend code path instead of replacing, fixes #770 #772

merged 1 commit into from
Sep 6, 2015

Conversation

tsloughter
Copy link
Collaborator

Related to #770

Using replace_path and I see the code path has properly replaced erlware_commons within the code path with the correct local copy that we are attempting to run the tests of.

Path ["/home/tristan/Devel/erlware_commons/_build/test/lib/proper/ebin",
      "/home/tristan/.cache/rebar3/plugins/rebar3_run/ebin",
      "/home/tristan/.cache/rebar3/plugins/rebar3_hex/ebin",
      "/home/tristan/.cache/rebar3/plugins/jsx/ebin",
      "/home/tristan/Devel/erlware_commons/../rebar3/rebar3/ssl_verify_hostname/ebin",
      "/home/tristan/Devel/erlware_commons/../rebar3/rebar3/relx/ebin",
      "/home/tristan/Devel/erlware_commons/../rebar3/rebar3/rebar/ebin",
      "/home/tristan/Devel/erlware_commons/../rebar3/rebar3/providers/ebin",
      "/home/tristan/Devel/erlware_commons/../rebar3/rebar3/getopt/ebin",
      "/home/tristan/Devel/erlware_commons/_build/test/lib/erlware_commons/ebin",
      "/home/tristan/Devel/erlware_commons/../rebar3/rebar3/bbmustache/ebin",
      "/home/tristan/Devel/rebar3/rebar3",
      ".",
      ...]

This causes the issue seen in #770 while with this patch we get:

Path ["/home/tristan/Devel/erlware_commons/_build/test/lib/erlware_commons/ebin",
      "/home/tristan/Devel/erlware_commons/_build/test/lib/proper/ebin",
      "/home/tristan/.cache/rebar3/plugins/rebar3_run/ebin",
      "/home/tristan/.cache/rebar3/plugins/rebar3_hex/ebin",
      "/home/tristan/.cache/rebar3/plugins/jsx/ebin",
      "/home/tristan/Devel/erlware_commons/../rebar3/rebar3/ssl_verify_hostname/ebin",
      "/home/tristan/Devel/erlware_commons/../rebar3/rebar3/relx/ebin",
      "/home/tristan/Devel/erlware_commons/../rebar3/rebar3/rebar/ebin",
      "/home/tristan/Devel/erlware_commons/../rebar3/rebar3/providers/ebin",
      "/home/tristan/Devel/erlware_commons/../rebar3/rebar3/getopt/ebin",
      "/home/tristan/Devel/erlware_commons/../rebar3/rebar3/bbmustache/ebin",
      "/home/tristan/Devel/rebar3/rebar3",
      ".",

Which works.

This may not be the right solution, but opening this PR for discussion.

ferd added a commit that referenced this pull request Sep 6, 2015
@ferd
Merge pull request #772 from tsloughter/eunit_fix
08f9b20 
delete and prepend code path instead of replacing, fixes #770
@ferd ferd merged commit 08f9b20 into erlang:master Sep 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsloughter @ferd