Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'bare compile' provider, for starters for use by mix #786

Merged
merged 5 commits into from
Sep 18, 2015

Conversation

tsloughter
Copy link
Collaborator

For #671

Example:

rebar3 bare compile

Note you'll need to set ERL_LIBS for any dependencies needing for compilation and plugins still go to _build/default/plugins.

@tsloughter tsloughter force-pushed the api_compile branch 2 times, most recently from 0f7fb7f to ec6a0c4 Compare September 9, 2015 02:36
@tsloughter tsloughter changed the title add rebar_api:compile/3, for starters for use by mix add 'bare compile' provider, for starters for use by mix Sep 9, 2015
@tsloughter tsloughter force-pushed the api_compile branch 2 times, most recently from 338868a to 45fc220 Compare September 9, 2015 02:38
@tsloughter
Copy link
Collaborator Author

Also note that it is marked to not be part of rebar3 help because it should not be something used by normal users.

@tsloughter
Copy link
Collaborator Author

@ferd I added include for each app in the escript to always be included. This would actually allow plugins to use ?PRV_ERROR without depending on providers.. Thoughts? I could revert that because it actually isn't needed after making the change to use -pz instead of -pa for the code paths.

@ferd
Copy link
Collaborator

ferd commented Sep 12, 2015

I don't exactly see how it could hurt, and it keeps more stuff working I guess.

@tsloughter
Copy link
Collaborator Author

I lied, it doesn't work.

@ericmj
Copy link
Contributor

ericmj commented Sep 13, 2015

This works great! Thank you!

@ericmj
Copy link
Contributor

ericmj commented Sep 14, 2015

Please start semver versioning your releases also because we need a version to install rebar3 via mix. Right now I use 0.0.0-beta.2 as version.

@ferd
Copy link
Collaborator

ferd commented Sep 14, 2015

We're still in beta, so semver means nothing :v

@ericmj
Copy link
Contributor

ericmj commented Sep 14, 2015

Semver might not have semantic meaning for pre-releases, but it's still a useful format for version strings and version ordering specification. We use it to order versions so that we can install the latest rebar version.

@tsloughter
Copy link
Collaborator Author

@ferd, semver also just means a specific format of writing versions so tools can parse it. We rely on it as well in our vsn parsing.

@ferd
Copy link
Collaborator

ferd commented Sep 15, 2015

So 3.0.0-beta.3 would be the next one. I guess we gotta switch a dash for a period in https://github.com/rebar/rebar3/blob/master/src/rebar.app.src#L6

@ericmj
Copy link
Contributor

ericmj commented Sep 15, 2015

Great, thanks. Can you also use that for the tags?

@ferd
Copy link
Collaborator

ferd commented Sep 15, 2015

I guess so, it's not a huge effort, but we can't retrofit old ones.

@tsloughter
Copy link
Collaborator Author

We are due a new release anyway.

ferd added a commit that referenced this pull request Sep 18, 2015
add 'bare compile' provider, for starters for use by mix
@ferd ferd merged commit d9638f8 into erlang:master Sep 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants