-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colorized dialyzer output #823
Conversation
Heads up that a lot of colors can already be handled by erlware_commons (we use them in rebar3) and the deps there can be reused. |
great work @Licenser |
Reached a pretty good place, all messages are colored, some I haven't seen in the wild are naively colored and perhaps can be improved later on. General color rules are: Readable text: Bold If something fails to output (i.e. there is an error it will fall back to the old output form). @ferd I Looked at the commons stuff but the code does not provide the kind of capabilities I need here, or the functions in question are not exported. |
Note: the failed test is a issue with fetching dependencies on travis. |
+1 @ferd merge if you are good with it. We have a lot built up as well and should cut beta-3. But with a proper version tag this time. |
@ferd thanks for the light terminal catch :) I'd have missed that, fixed it now it's "bold" not "bold white" and works on both light and dark backgrounds: |
Merging when tests pass. |
On second look, your screenshot seems to show a bug: |
It appears that the line |
Some nicer dialyzer messages, making larger ones readable.
what was
https://monosnap.com/file/nARGsi1CvHoliGTukbRgdUFEvAe7cK
is now
https://monosnap.com/file/HgKtFqC90RqoKU5Du4wN5GYPnUd50w