Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell handles all possible relx app formats #839

Merged
merged 1 commit into from
Sep 26, 2015
Merged

Conversation

ferd
Copy link
Collaborator

@ferd ferd commented Sep 26, 2015

The list of applications in the relx config section could contain
tuples. The tuple will either contain a version constraint for the app,
the start type of the app or both.

This fix silently expands {shell_apps, [Apps]} to support the same
format.

fixes #764

@tsloughter
Copy link
Collaborator

Should it use application:load/1 on those marked as load?

@ferd
Copy link
Collaborator Author

ferd commented Sep 26, 2015

It already does and loads all apps first, but I guess I haven't filtered these. Fixing.

The list of applications in the relx config section could contain
tuples. The tuple will either contain a version constraint for the app,
the start type of the app or both.

This fix silently expands `{shell_apps, [Apps]}` to support the same
format.
tsloughter added a commit that referenced this pull request Sep 26, 2015
Shell handles all possible relx app formats
@tsloughter tsloughter merged commit b6afc1d into master Sep 26, 2015
@ferd ferd deleted the fix-shell-load branch September 26, 2015 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shell provider doesn't properly parse relx list of applications
2 participants