Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for cover under new compiler/eunit/ct #905

Merged
merged 1 commit into from
Nov 4, 2015

Conversation

talentdeficit
Copy link
Contributor

No description provided.

* only try to cover compile directories that actually exist
* recover from failures where source files don't contain required
  attributes for cover compilation and print warning
tsloughter added a commit that referenced this pull request Nov 4, 2015
fixes for cover under new compiler/eunit/ct
@tsloughter tsloughter merged commit f02ec39 into erlang:master Nov 4, 2015
@lpgauth
Copy link
Contributor

lpgauth commented Nov 5, 2015

Not fixed for me... https://gist.github.com/lpgauth/8dce1737056c89737410

@talentdeficit
Copy link
Contributor Author

@lpgauth are you using any plugins other than the erlydtl plugin? do you have any other beam files that are produced outside the built in rebar3 build chain?

@lpgauth
Copy link
Contributor

lpgauth commented Nov 5, 2015

No beams from the outside.

Plugins:

{plugins, [
  {pc, ".*",
    {git, "https://github.com/blt/port_compiler.git", {branch, "master"}}},
  {rebar3_eqc, ".*",
    {git, "https://github.com/kellymclaughlin/rebar3-eqc-plugin.git", {tag, "0.0.8"}}},
  {rebar3_erlydtl_plugin, ".*",
    {git, "https://github.com/lpgauth/rebar3_erlydtl_plugin.git", {branch, adgear}}}
]}.

@talentdeficit
Copy link
Contributor Author

@lpgauth i'm unable to reproduce. could you rm -rf _build and try again with latest head? if you still see the failure i'd like to talk to you about trying to reduce this to a test case so i can try to figure out what is going on. there's an explicit guard against exactly the failure you're seeing in the cover provider so something must be calling cover:compile outside the normal code path

@lpgauth
Copy link
Contributor

lpgauth commented Nov 5, 2015

Ok, I dig a little bit and it seems more a cover problem then rebar3. I'll open a pull req upstream.

@lpgauth
Copy link
Contributor

lpgauth commented Nov 5, 2015

Opened: erlang/otp#885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants