include Sean Cribbs eunit formatter by default #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm ok with it, but I don't really have a lot of time to do debugging and maintenance of eunit_formatters. However, I'm happy to add collaborators if someone wants to take over the day-to-day. |
|
Understandable. I'd be happy to be a collaborator to handle the day-to-day issues if they come up. |
|
Done! |
|
+1 million. |
| EUnitOpts1 = case proplists:get_value(verbose, Opts, false) of | ||
| true -> set_verbose(EUnitOpts); | ||
| false -> EUnitOpts | ||
| end, |
There was a problem hiding this comment.
misaligned case/end, -millions
|
+1 |
tsloughter
force-pushed
the
eunit_formatters
branch
from
4347c97
to
87d9edc
Compare
ferd
added a commit
that referenced
this pull request
Nov 13, 2015
include Sean Cribbs eunit formatter by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinging @seancribbs in case he has any warnings about making this a default.
It can be turned off by either the user already having a
reportkey in their eunit opts or settingeunit_formatterstofalseineunit_opts.