Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preserve attributes when copying files in rebar_utils:cp_r for unix #941

Merged
merged 1 commit into from
Nov 25, 2015
Merged

preserve attributes when copying files in rebar_utils:cp_r for unix #941

merged 1 commit into from
Nov 25, 2015

Conversation

tsloughter
Copy link
Collaborator

No description provided.

@tsloughter
Copy link
Collaborator Author

Does anyone know why we shell out to cp -R instead of using ec_file:copy/3?

This PR makes it so copying preserves the modified time of the file, this fixes a bug with extra_src where it would recompile all modules in the extra src dirs because the compiler considered them modified.

@talentdeficit
Copy link
Contributor

git blame seems to think that function has been around since 2009. so no good reason probably

ferd added a commit that referenced this pull request Nov 25, 2015
@ferd
Merge pull request #941 from tsloughter/cp_r_p
be18535 
preserve attributes when copying files in rebar_utils:cp_r for unix
@ferd ferd merged commit be18535 into erlang:master Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsloughter @talentdeficit @ferd