Allow bootstrap to pick up existing Hex cache and deps #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, not positive about this. I was hoping that it would simply use the available registry and |
|
Sounds good. I'll rework it the way you described. |
This detects existence of Hex registry at $HOME/.cache/rebar3/hex/default/registry and skips "rebar3 update" step. It also detect presence of bootstrap dependencies in _build/default/lib/ and skips fetching them.
gleber
changed the title
|
@tsloughter Tristan, I've reworked this PR to "do the right thing automatically". It looks a bit too simple... Am I missing anything? I am not 100% sure if profiles mechanism can badly interact with this patch. |
|
Cool +1. @ferd you ok with this? |
ferd
added a commit
that referenced
this pull request
Jan 6, 2016
Allow bootstrap to pick up existing Hex cache and deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows rebar to pick up existing assets, if present:
@tsloughter, does this approach look good?
Rationale: this allows to build rebar3 in a build system, which requires it to be hermetic. This is the case for Debian (they are working on making their builds reproducible) and for Nix. I am working on Nix packaging for Erlang using rebar3 and hex.pm here:
NixOS/nixpkgs#11651
Currently I have to apply the following patch to make it hermetic:
https://github.com/gleber/nixpkgs/blob/add-erlang-modules/pkgs/development/tools/build-managers/rebar3/hermetic-bootstrap.patch
And in the build rules I am manually providing plugins to build process:
https://github.com/NixOS/nixpkgs/pull/11651/files#diff-177ea02978ffc72f964033695c5e023eR93
and provide a snapshot of registry:
https://github.com/NixOS/nixpkgs/pull/11651/files#diff-177ea02978ffc72f964033695c5e023eR9