Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internet Explorer 11 #239

Closed
allforabit opened this issue Jul 5, 2017 · 10 comments
Closed

Internet Explorer 11 #239

allforabit opened this issue Jul 5, 2017 · 10 comments

Comments

@allforabit
Copy link

It's not working at the moment on internet explorer (tested on Windows 10). It's just giving a white screen, even for the documentation site (http://jxnblk.com/rebass). It's giving the following error in the console:

SCRIPT438: Object doesn't support property or method 'from'

@jxnblk
Copy link
Member

jxnblk commented Jul 5, 2017

Are you having this issue with something other than the docs site as well?

@jxnblk
Copy link
Member

jxnblk commented Jul 5, 2017

I wonder if it's related to what's described here: https://stackoverflow.com/questions/13975922/script438-object-doesnt-support-property-or-method-ie

@allforabit
Copy link
Author

Hi, yes I got the error with a site I'm working on that uses the latest version of the library. I'll have another look tomorrow to see if I can pinpoint the particular line that is causing the issue.

@jxnblk
Copy link
Member

jxnblk commented Jul 6, 2017

Okay, thanks. I can try digging in on my windows machine later. After thinking about the comment in Stack Overflow the docs do use ids that are identical to the component names and there might be an issue with how react-live handles scope. If you could rule out the id thing in your own app that'd be helpful

@allforabit
Copy link
Author

Here's the error on my local project. It looks like it's an issue with palx.

19 | var hueLength = length;
20 | var hueStep = 360 / hueLength;
21 | return function (base) {

22 | var hues = Array.from({ length: hueLength }).map(function (n, i) {
23 | return Math.floor((base + i * hueStep) % 360);
24 | });
25 |

I could actually fix it by including the polyfill here:
https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Array/from#Polyfill

I'm using create-react-app, maybe there's a setting that makes the javascript more backward compliant.

I've tested it on Edge as well and it works fine on that without needing the polyfill.

Thanks for the great framework!

@jxnblk
Copy link
Member

jxnblk commented Jul 6, 2017

Thanks for looking into this - might be a good idea to add this ponyfill to palx https://www.npmjs.com/package/array-from

@allforabit
Copy link
Author

Hi, yes I think it could be a good idea as apart from this works very well in IE.

@gowrimanoharir
Copy link

Hi
I am working on a CRA app which uses Rebass, and exact same issue is happening in our project as well. Rebass is a great tool for us and would be helpful if this issue is fixed for IE11.

Please let me know if any more details are needed.

Thank you!!

@mjsisley
Copy link

mjsisley commented Feb 8, 2018

The issue is fixed with this PR to palx: jxnblk/palx#8. I ended up just using a fork of rebass that depended on a fork of palx on the project I was working on.

@jxnblk
Copy link
Member

jxnblk commented Jun 10, 2018

Closing this out since palx is no longer a dependency in v2

@jxnblk jxnblk closed this as completed Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants