Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme #30

Merged
merged 4 commits into from
Aug 17, 2017
Merged

Update readme #30

merged 4 commits into from
Aug 17, 2017

Conversation

svenwltr
Copy link
Member

solves parts of #29

@svenwltr svenwltr self-assigned this Aug 13, 2017
bjoernhaeuser
bjoernhaeuser previously approved these changes Aug 14, 2017
View reviewed changes
Copy link
Member

@bjoernhaeuser bjoernhaeuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

README.md Outdated

## Caution!

Be aware that *aws-nuke* is a very descructive Tool, hence you have to be very
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tool

README.md Outdated

To reduce the blast radius of accidents, there are some safety precautions:

1. By default *aws-nuke* only lists all nukable resources. You need to add
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nukeable

README.md Outdated
you want to nuke is part of this blacklist, *aws-nuke* will abort. It is
recommended, that you add every production account to this blacklist.
6. To ensure you just ignore the blacklisting feature, the blacklist must
container at least one Account ID.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contain

README.md Outdated
and add it to a central repository. This way the account blacklist is way
easier to manage and keep up to date.

Feel free to create an issue, if you have any ideas to improve the safty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

safety

@svenwltr
Copy link
Member Author

I added a usage part. Is that maybe too much?

bjoernhaeuser
bjoernhaeuser previously approved these changes Aug 16, 2017
View reviewed changes
Copy link
Member

@bjoernhaeuser bjoernhaeuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like it very much

@svenwltr svenwltr mentioned this pull request Aug 17, 2017
Closed
23 tasks
@svenwltr
Copy link
Member Author

I now added some more sections.

stephanlindauer
stephanlindauer approved these changes Aug 17, 2017
View reviewed changes
Copy link
Contributor

@stephanlindauer stephanlindauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!
how would you go about releasing this? new repo or just set this one to public?

@svenwltr
Copy link
Member Author

Just making this one public. I don't see any benefit in a new repo.

@svenwltr svenwltr merged commit 77d23e2 into master Aug 17, 2017
@svenwltr svenwltr deleted the update-readme branch August 17, 2017 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanlindauer stephanlindauer stephanlindauer approved these changes

@bjoernhaeuser bjoernhaeuser bjoernhaeuser approved these changes

Assignees

@svenwltr svenwltr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@svenwltr @stephanlindauer @bjoernhaeuser