Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcery refactored master branch #3

Merged
merged 1 commit into from
May 11, 2020
Merged

Sourcery refactored master branch #3

merged 1 commit into from
May 11, 2020

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented May 11, 2020

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

for f in 'foo', 'bar':
for _ in 'foo', 'bar':
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function RunTest.test_error refactored with the following changes:

  • Replace unused for index with underscore

Comment on lines +35 to -37
cmd = 'ls foo setup.py bar'
for shell in False, True:
self.lines.clear()
cmd = 'ls foo setup.py bar'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function RunTest.test_log refactored with the following changes:

  • Hoist statements out of for/while loops

Comment on lines +50 to -51
cmd = 'ls foo setup.py bar'
for shell in False, True:
cmd = 'ls foo setup.py bar'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function RunTest.test_run refactored with the following changes:

  • Hoist statements out of for/while loops

@rec rec merged commit 8a42caa into master May 11, 2020
@rec rec deleted the sourcery/master branch May 18, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants