Preserve comments in AST #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Woah, this is great!! Definitely happy to add this functionality. Only concern is that we're modifying the Buf lex files. Just means we'll have to merge their changes in if they make any. Not a huge deal. Let me take a look at the PR and get back to you. |
|
Merged! Released in 1.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I've been exploring tools for parsing proto files to extract documentation from messages and fields, and I found your cool project. I like the simplicity, but for my use case, I need to access the comments in the proto files as well - this PR solves that.
I don't know if this is something you think is within the scope of your project, but here goes.
All the best,
Jeppe